* [PATCH] drm/komeda: mark PM functions as __maybe_unused
@ 2020-01-07 21:53 Arnd Bergmann
2020-01-08 9:56 ` james qian wang
2020-03-06 3:59 ` james qian wang (Arm Technology China)
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2020-01-07 21:53 UTC (permalink / raw)
To: james qian wang (Arm Technology China), Liviu Dudau,
Mihail Atanassov, Brian Starkey, David Airlie, Daniel Vetter
Cc: Arnd Bergmann, Nathan Chancellor, Lowry Li (Arm Technology China),
dri-devel, linux-kernel
Without this, we get a couple of warnings when CONFIG_PM
is disabled:
drivers/gpu/drm/arm/display/komeda/komeda_drv.c:156:12: error: 'komeda_rt_pm_resume' defined but not used [-Werror=unused-function]
static int komeda_rt_pm_resume(struct device *dev)
^~~~~~~~~~~~~~~~~~~
drivers/gpu/drm/arm/display/komeda/komeda_drv.c:149:12: error: 'komeda_rt_pm_suspend' defined but not used [-Werror=unused-function]
static int komeda_rt_pm_suspend(struct device *dev)
^~~~~~~~~~~~~~~~~~~~
Fixes: efb465088518 ("drm/komeda: Add runtime_pm support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/arm/display/komeda/komeda_drv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
index ea5cd1e17304..e7933930a657 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
@@ -146,14 +146,14 @@ static const struct of_device_id komeda_of_match[] = {
MODULE_DEVICE_TABLE(of, komeda_of_match);
-static int komeda_rt_pm_suspend(struct device *dev)
+static int __maybe_unused komeda_rt_pm_suspend(struct device *dev)
{
struct komeda_drv *mdrv = dev_get_drvdata(dev);
return komeda_dev_suspend(mdrv->mdev);
}
-static int komeda_rt_pm_resume(struct device *dev)
+static int __maybe_unused komeda_rt_pm_resume(struct device *dev)
{
struct komeda_drv *mdrv = dev_get_drvdata(dev);
--
2.20.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/komeda: mark PM functions as __maybe_unused
2020-01-07 21:53 [PATCH] drm/komeda: mark PM functions as __maybe_unused Arnd Bergmann
@ 2020-01-08 9:56 ` james qian wang
2020-03-06 3:59 ` james qian wang (Arm Technology China)
1 sibling, 0 replies; 3+ messages in thread
From: james qian wang @ 2020-01-08 9:56 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Liviu Dudau, Mihail Atanassov, Brian Starkey, David Airlie,
Daniel Vetter, Nathan Chancellor, Lowry Li,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, nd
On Tue, Jan 07, 2020 at 10:53:19PM +0100, Arnd Bergmann wrote:
> Without this, we get a couple of warnings when CONFIG_PM
> is disabled:
>
> drivers/gpu/drm/arm/display/komeda/komeda_drv.c:156:12: error: 'komeda_rt_pm_resume' defined but not used [-Werror=unused-function]
> static int komeda_rt_pm_resume(struct device *dev)
> ^~~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/arm/display/komeda/komeda_drv.c:149:12: error: 'komeda_rt_pm_suspend' defined but not used [-Werror=unused-function]
> static int komeda_rt_pm_suspend(struct device *dev)
> ^~~~~~~~~~~~~~~~~~~~
>
> Fixes: efb465088518 ("drm/komeda: Add runtime_pm support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_drv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
> index ea5cd1e17304..e7933930a657 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
> @@ -146,14 +146,14 @@ static const struct of_device_id komeda_of_match[] = {
>
> MODULE_DEVICE_TABLE(of, komeda_of_match);
>
> -static int komeda_rt_pm_suspend(struct device *dev)
> +static int __maybe_unused komeda_rt_pm_suspend(struct device *dev)
> {
> struct komeda_drv *mdrv = dev_get_drvdata(dev);
>
> return komeda_dev_suspend(mdrv->mdev);
> }
>
> -static int komeda_rt_pm_resume(struct device *dev)
> +static int __maybe_unused komeda_rt_pm_resume(struct device *dev)
> {
> struct komeda_drv *mdrv = dev_get_drvdata(dev);
>
Hi Arnd:
Thank you for the patch.
Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com>
James
> --
> 2.20.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: drm/komeda: mark PM functions as __maybe_unused
2020-01-07 21:53 [PATCH] drm/komeda: mark PM functions as __maybe_unused Arnd Bergmann
2020-01-08 9:56 ` james qian wang
@ 2020-03-06 3:59 ` james qian wang (Arm Technology China)
1 sibling, 0 replies; 3+ messages in thread
From: james qian wang (Arm Technology China) @ 2020-03-06 3:59 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Liviu Dudau, Mihail Atanassov, Brian Starkey, David Airlie,
Daniel Vetter, Nathan Chancellor, Lowry Li (Arm Technology China),
dri-devel, linux-kernel, nd
On Tue, Jan 07, 2020 at 10:53:19PM +0100, Arnd Bergmann wrote:
> Without this, we get a couple of warnings when CONFIG_PM
> is disabled:
>
> drivers/gpu/drm/arm/display/komeda/komeda_drv.c:156:12: error: 'komeda_rt_pm_resume' defined but not used [-Werror=unused-function]
> static int komeda_rt_pm_resume(struct device *dev)
> ^~~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/arm/display/komeda/komeda_drv.c:149:12: error: 'komeda_rt_pm_suspend' defined but not used [-Werror=unused-function]
> static int komeda_rt_pm_suspend(struct device *dev)
> ^~~~~~~~~~~~~~~~~~~~
>
> Fixes: efb465088518 ("drm/komeda: Add runtime_pm support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com>
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_drv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
> index ea5cd1e17304..e7933930a657 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
> @@ -146,14 +146,14 @@ static const struct of_device_id komeda_of_match[] = {
>
> MODULE_DEVICE_TABLE(of, komeda_of_match);
>
> -static int komeda_rt_pm_suspend(struct device *dev)
> +static int __maybe_unused komeda_rt_pm_suspend(struct device *dev)
> {
> struct komeda_drv *mdrv = dev_get_drvdata(dev);
>
> return komeda_dev_suspend(mdrv->mdev);
> }
>
> -static int komeda_rt_pm_resume(struct device *dev)
> +static int __maybe_unused komeda_rt_pm_resume(struct device *dev)
> {
> struct komeda_drv *mdrv = dev_get_drvdata(dev);
>
Applied to drm-misc-fixes 9803aac7b5508718989e4cde11b854fc01037b01
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-06 3:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-07 21:53 [PATCH] drm/komeda: mark PM functions as __maybe_unused Arnd Bergmann
2020-01-08 9:56 ` james qian wang
2020-03-06 3:59 ` james qian wang (Arm Technology China)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox