From: Borislav Petkov <bp@alien8.de>
To: Nick Terrell <terrelln@fb.com>
Cc: Nick Terrell <nickrterrell@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Chris Mason <clm@fb.com>,
"linux-kbuild@vger.kernel.org" <linux-kbuild@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
Petr Malat <oss@malat.biz>, Kees Cook <keescook@chromium.org>,
Kernel Team <Kernel-team@fb.com>,
Adam Borowski <kilobyte@angband.pl>,
Patrick Williams <patrickw3@fb.com>,
Michael van der Westhuizen <rmikey@fb.com>,
"mingo@kernel.org" <mingo@kernel.org>,
Patrick Williams <patrick@stwcx.xyz>,
Sedat Dilek <sedat.dilek@gmail.com>
Subject: Re: [PATCH v4 6/8] x86: bump ZO_z_extra_bytes margin for zstd
Date: Thu, 2 Apr 2020 17:58:10 +0200 [thread overview]
Message-ID: <20200402155810.GD9352@zn.tnic> (raw)
In-Reply-To: <D45F637D-6BB0-4F08-BEBE-FAB9B56F36F6@fb.com>
On Wed, Apr 01, 2020 at 05:33:03PM +0000, Nick Terrell wrote:
> The code is currently written so that all the compression algorithms use the
> same ZO_z_extra_bytes. It is taken to be the maximum of the growth rate
> plus the maximum fixed overhead. Just a few lines above is the comment:
>
> # … Hence safety
> # margin should be updated to cover all decompressors so that we don't
> # need to deal with each of them separately. Please check
> # the description in lib/decompressor_xxx.c for specific information.
>
> So I was been following the guidance in the comments.
Please state that in the commit message when you send your next
revision.
> Does it matter? I’m not an expert here,
Huh, you're only sending the code then? Or what do you mean with not
being an expert?
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-04-02 15:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 5:39 [PATCH v4 0/8] Add support for ZSTD-compressed kernel and initramfs Nick Terrell
2020-04-01 5:39 ` [PATCH v4 1/8] lib: prepare zstd for preboot environment Nick Terrell
2020-04-01 5:39 ` [PATCH v4 2/8] lib: prepare xxhash " Nick Terrell
2020-04-01 5:39 ` [PATCH v4 3/8] lib: add zstd support to decompress Nick Terrell
2020-04-01 5:39 ` [PATCH v4 4/8] init: add support for zstd compressed kernel Nick Terrell
2020-04-01 5:39 ` [PATCH v4 5/8] usr: add support for zstd compressed initramfs Nick Terrell
2020-04-01 5:39 ` [PATCH v4 6/8] x86: bump ZO_z_extra_bytes margin for zstd Nick Terrell
2020-04-01 9:33 ` Borislav Petkov
2020-04-01 17:33 ` Nick Terrell
2020-04-02 15:58 ` Borislav Petkov [this message]
2020-04-02 20:25 ` Nick Terrell
2020-04-03 10:19 ` Borislav Petkov
2020-04-06 10:47 ` Sedat Dilek
2020-04-01 5:39 ` [PATCH v4 7/8] x86: Add support for ZSTD compressed kernel Nick Terrell
2020-04-01 5:39 ` [PATCH v4 8/8] .gitignore: add ZSTD-compressed files Nick Terrell
2020-04-01 10:59 ` [PATCH v4 0/8] Add support for ZSTD-compressed kernel and initramfs Gabriel C
2020-04-01 17:36 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200402155810.GD9352@zn.tnic \
--to=bp@alien8.de \
--cc=Kernel-team@fb.com \
--cc=clm@fb.com \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=kilobyte@angband.pl \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=nickrterrell@gmail.com \
--cc=oss@malat.biz \
--cc=patrick@stwcx.xyz \
--cc=patrickw3@fb.com \
--cc=rmikey@fb.com \
--cc=sedat.dilek@gmail.com \
--cc=terrelln@fb.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox