From: Jason Gunthorpe <jgg@ziepe.ca>
To: "Denis V. Lunev" <den@openvz.org>
Cc: Konstantin Khorenko <khorenko@virtuozzo.com>,
Faisal Latif <faisal.latif@intel.com>,
Shiraz Saleem <shiraz.saleem@intel.com>,
Doug Ledford <dledford@redhat.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] i40iw: remove bogus call to netdev_master_upper_dev_get
Date: Mon, 4 May 2020 15:52:14 -0300 [thread overview]
Message-ID: <20200504185214.GA8086@ziepe.ca> (raw)
In-Reply-To: <20200428131511.11049-1-den@openvz.org>
On Tue, Apr 28, 2020 at 04:15:11PM +0300, Denis V. Lunev wrote:
> Local variable netdev is not used in these calls.
>
> It should be noted, that this change is required to work in bonded mode.
> In the other case we would get the following assert:
> "RTNL: assertion failed at net/core/dev.c (5665)"
> with the calltrace as follows:
> dump_stack+0x19/0x1b
> netdev_master_upper_dev_get+0x61/0x70
> i40iw_addr_resolve_neigh+0x1e8/0x220
> i40iw_make_cm_node+0x296/0x700
> ? i40iw_find_listener.isra.10+0xcc/0x110
> i40iw_receive_ilq+0x3d4/0x810
> i40iw_puda_poll_completion+0x341/0x420
> i40iw_process_ceq+0xa5/0x280
> i40iw_ceq_dpc+0x1e/0x40
> tasklet_action+0x83/0x140
> __do_softirq+0x125/0x2bb
> call_softirq+0x1c/0x30
> do_softirq+0x65/0xa0
> irq_exit+0x105/0x110
> do_IRQ+0x56/0xf0
> common_interrupt+0x16a/0x16a
> ? cpuidle_enter_state+0x57/0xd0
> cpuidle_idle_call+0xde/0x230
> arch_cpu_idle+0xe/0xc0
> cpu_startup_entry+0x14a/0x1e0
> start_secondary+0x1f7/0x270
> start_cpu+0x5/0x14
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Konstantin Khorenko <khorenko@virtuozzo.com>
> CC: Faisal Latif <faisal.latif@intel.com>
> CC: Shiraz Saleem <shiraz.saleem@intel.com>
> CC: Doug Ledford <dledford@redhat.com>
> CC: Jason Gunthorpe <jgg@ziepe.ca>
> CC: linux-rdma@vger.kernel.org
> CC: linux-kernel@vger.kernel.org
> Acked-by: Shiraz Saleem <shiraz.saleem@intel.com>
> drivers/infiniband/hw/i40iw/i40iw_cm.c | 8 --------
> 1 file changed, 8 deletions(-)
Applied to for-rc, thanks
JAson
prev parent reply other threads:[~2020-05-04 18:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 13:15 [PATCH 1/1] i40iw: remove bogus call to netdev_master_upper_dev_get Denis V. Lunev
2020-04-29 15:33 ` Saleem, Shiraz
2020-05-04 18:52 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200504185214.GA8086@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=den@openvz.org \
--cc=dledford@redhat.com \
--cc=faisal.latif@intel.com \
--cc=khorenko@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=shiraz.saleem@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox