The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, jmattson@google.com
Subject: Re: [PATCH] KVM: x86: fix DR6 delivery for emulated hardware breakpoint
Date: Tue, 5 May 2020 10:15:41 -0400	[thread overview]
Message-ID: <20200505141541.GI6299@xz-x1> (raw)
In-Reply-To: <20200505113449.18478-1-pbonzini@redhat.com>

On Tue, May 05, 2020 at 07:34:49AM -0400, Paolo Bonzini wrote:
> Go through kvm_queue_exception_p so that the payload is correctly delivered
> through the exit qualification, and add a kvm_update_dr6 call to
> kvm_deliver_exception_payload that is needed on AMD.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

I still think we could also change this in handle_exception_nmi() and
handle_dr() as mentioned in the other thread, but no strong opinion:

Reviewed-by: Peter Xu <peterx@redhat.com>

Thanks,

-- 
Peter Xu


  reply	other threads:[~2020-05-05 14:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-05 11:34 [PATCH] KVM: x86: fix DR6 delivery for emulated hardware breakpoint Paolo Bonzini
2020-05-05 14:15 ` Peter Xu [this message]
2020-05-06  0:33 ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200505141541.GI6299@xz-x1 \
    --to=peterx@redhat.com \
    --cc=jmattson@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox