* [PATCH] mfd: remove max8907 wake_base
@ 2020-04-30 10:04 mjz
2020-05-15 10:42 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: mjz @ 2020-04-30 10:04 UTC (permalink / raw)
To: LKLM; +Cc: 付尧, Gyungoh Yoo, Greg Kroah-Hartman, Mark Brown
regmap irqchip should not use wake_base the same as mask_base.
if use enable_irq_wake in drivers can cause mask_base write, cause
the disabled irq to enable.
Signed-off-by: maijianzhang <maijianzhang@allwinnertech.com>
---
drivers/mfd/max8907.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mfd/max8907.c b/drivers/mfd/max8907.c
index d44baafd9d14..6346a3985088 100644
--- a/drivers/mfd/max8907.c
+++ b/drivers/mfd/max8907.c
@@ -130,7 +130,6 @@ static const struct regmap_irq_chip max8907_chg_irq_chip = {
.name = "max8907 chg",
.status_base = MAX8907_REG_CHG_IRQ1,
.mask_base = MAX8907_REG_CHG_IRQ1_MASK,
- .wake_base = MAX8907_REG_CHG_IRQ1_MASK,
.irq_reg_stride = MAX8907_REG_CHG_IRQ2 - MAX8907_REG_CHG_IRQ1,
.num_regs = 2,
.irqs = max8907_chg_irqs,
--
2.19.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] mfd: remove max8907 wake_base
2020-04-30 10:04 [PATCH] mfd: remove max8907 wake_base mjz
@ 2020-05-15 10:42 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2020-05-15 10:42 UTC (permalink / raw)
To: LKLM, Gyungoh Yoo, Greg Kroah-Hartman, Mark Brown
On Thu, 30 Apr 2020, mjz wrote:
Please could you change your sender and SoB to your proper name and
ensure they match please.
> regmap irqchip should not use wake_base the same as mask_base.
> if use enable_irq_wake in drivers can cause mask_base write, cause
> the disabled irq to enable.
Could you please try to use correct grammar in commit messages.
Names of things should start with capital letters, as should
sentences.
> Signed-off-by: maijianzhang <maijianzhang@allwinnertech.com>
> ---
> drivers/mfd/max8907.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mfd/max8907.c b/drivers/mfd/max8907.c
> index d44baafd9d14..6346a3985088 100644
> --- a/drivers/mfd/max8907.c
> +++ b/drivers/mfd/max8907.c
> @@ -130,7 +130,6 @@ static const struct regmap_irq_chip max8907_chg_irq_chip = {
> .name = "max8907 chg",
> .status_base = MAX8907_REG_CHG_IRQ1,
> .mask_base = MAX8907_REG_CHG_IRQ1_MASK,
> - .wake_base = MAX8907_REG_CHG_IRQ1_MASK,
> .irq_reg_stride = MAX8907_REG_CHG_IRQ2 - MAX8907_REG_CHG_IRQ1,
> .num_regs = 2,
> .irqs = max8907_chg_irqs,
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-15 10:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-30 10:04 [PATCH] mfd: remove max8907 wake_base mjz
2020-05-15 10:42 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox