* [PATCH 0/2] mfd: constify pointers
@ 2020-05-16 11:06 Tomas Winkler
2020-05-16 11:06 ` [PATCH 1/2] mfd: constify properties in mfd_cell Tomas Winkler
2020-05-16 11:06 ` [PATCH 2/2] mfd: mfd_cell: constify platform_data Tomas Winkler
0 siblings, 2 replies; 6+ messages in thread
From: Tomas Winkler @ 2020-05-16 11:06 UTC (permalink / raw)
To: Lee Jones, Andy Shevchenko, Greg Kroah-Hartman
Cc: linux-kernel, Tomas Winkler
Constify properties and platform_data in mfd cells
Tomas Winkler (2):
mfd: constify properties in mfd_cell
mfd: mfd_cell: constify platform_data
include/linux/mfd/core.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
2.21.3
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] mfd: constify properties in mfd_cell
2020-05-16 11:06 [PATCH 0/2] mfd: constify pointers Tomas Winkler
@ 2020-05-16 11:06 ` Tomas Winkler
2020-05-20 10:50 ` Lee Jones
2020-05-16 11:06 ` [PATCH 2/2] mfd: mfd_cell: constify platform_data Tomas Winkler
1 sibling, 1 reply; 6+ messages in thread
From: Tomas Winkler @ 2020-05-16 11:06 UTC (permalink / raw)
To: Lee Jones, Andy Shevchenko, Greg Kroah-Hartman
Cc: linux-kernel, Tomas Winkler
Constify 'struct property_entry *properties' in
mfd_cell It is always passed
around as a pointer const struct.
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
---
include/linux/mfd/core.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/mfd/core.h b/include/linux/mfd/core.h
index d01d1299e49d..7e5ac3c00891 100644
--- a/include/linux/mfd/core.h
+++ b/include/linux/mfd/core.h
@@ -70,7 +70,7 @@ struct mfd_cell {
size_t pdata_size;
/* device properties passed to the sub devices drivers */
- struct property_entry *properties;
+ const struct property_entry *properties;
/*
* Device Tree compatible string
--
2.21.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] mfd: constify properties in mfd_cell
2020-05-16 11:06 ` [PATCH 1/2] mfd: constify properties in mfd_cell Tomas Winkler
@ 2020-05-20 10:50 ` Lee Jones
0 siblings, 0 replies; 6+ messages in thread
From: Lee Jones @ 2020-05-20 10:50 UTC (permalink / raw)
To: Tomas Winkler; +Cc: Andy Shevchenko, Greg Kroah-Hartman, linux-kernel
On Sat, 16 May 2020, Tomas Winkler wrote:
> Constify 'struct property_entry *properties' in
> mfd_cell It is always passed
> around as a pointer const struct.
Apart from the odd commit log formatting ...
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> ---
> include/linux/mfd/core.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
... patch seems fine.
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] mfd: mfd_cell: constify platform_data
2020-05-16 11:06 [PATCH 0/2] mfd: constify pointers Tomas Winkler
2020-05-16 11:06 ` [PATCH 1/2] mfd: constify properties in mfd_cell Tomas Winkler
@ 2020-05-16 11:06 ` Tomas Winkler
2020-05-16 13:53 ` kbuild test robot
1 sibling, 1 reply; 6+ messages in thread
From: Tomas Winkler @ 2020-05-16 11:06 UTC (permalink / raw)
To: Lee Jones, Andy Shevchenko, Greg Kroah-Hartman
Cc: linux-kernel, Tomas Winkler
platform_data is duplicated into platform_device platform_data
via platform_device_add_data() and is not modified.
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
---
include/linux/mfd/core.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/mfd/core.h b/include/linux/mfd/core.h
index 7e5ac3c00891..6919aaee33dc 100644
--- a/include/linux/mfd/core.h
+++ b/include/linux/mfd/core.h
@@ -66,7 +66,7 @@ struct mfd_cell {
int (*resume)(struct platform_device *dev);
/* platform data passed to the sub devices drivers */
- void *platform_data;
+ const void *platform_data;
size_t pdata_size;
/* device properties passed to the sub devices drivers */
--
2.21.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] mfd: mfd_cell: constify platform_data
2020-05-16 11:06 ` [PATCH 2/2] mfd: mfd_cell: constify platform_data Tomas Winkler
@ 2020-05-16 13:53 ` kbuild test robot
2020-05-18 8:45 ` Lee Jones
0 siblings, 1 reply; 6+ messages in thread
From: kbuild test robot @ 2020-05-16 13:53 UTC (permalink / raw)
To: Tomas Winkler, Lee Jones, Andy Shevchenko, Greg Kroah-Hartman
Cc: kbuild-all, clang-built-linux, linux-kernel, Tomas Winkler
[-- Attachment #1: Type: text/plain, Size: 3776 bytes --]
Hi Tomas,
I love your patch! Yet something to improve:
[auto build test ERROR on ljones-mfd/for-mfd-next]
[also build test ERROR on v5.7-rc5 next-20200515]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Tomas-Winkler/mfd-constify-pointers/20200516-190733
base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
config: arm-randconfig-r006-20200515 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 13d44b2a0c7ef404b13b16644765977cd5310fe2)
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
>> drivers/hid/hid-sensor-hub.c:738:33: error: initializing 'struct hid_sensor_hub_device *' with an expression of type 'const void *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
struct hid_sensor_hub_device *hsdev =
^
1 error generated.
vim +738 drivers/hid/hid-sensor-hub.c
401ca24fb34aee0 srinivas pandruvada 2012-09-05 726
401ca24fb34aee0 srinivas pandruvada 2012-09-05 727 static void sensor_hub_remove(struct hid_device *hdev)
401ca24fb34aee0 srinivas pandruvada 2012-09-05 728 {
401ca24fb34aee0 srinivas pandruvada 2012-09-05 729 struct sensor_hub_data *data = hid_get_drvdata(hdev);
401ca24fb34aee0 srinivas pandruvada 2012-09-05 730 unsigned long flags;
e651a1da442ae02 Srinivas Pandruvada 2015-02-19 731 int i;
401ca24fb34aee0 srinivas pandruvada 2012-09-05 732
401ca24fb34aee0 srinivas pandruvada 2012-09-05 733 hid_dbg(hdev, " hardware removed\n");
401ca24fb34aee0 srinivas pandruvada 2012-09-05 734 hid_hw_close(hdev);
f2f13a68c37c13a Axel Lin 2012-09-19 735 hid_hw_stop(hdev);
401ca24fb34aee0 srinivas pandruvada 2012-09-05 736 spin_lock_irqsave(&data->lock, flags);
e651a1da442ae02 Srinivas Pandruvada 2015-02-19 737 for (i = 0; i < data->hid_sensor_client_cnt; ++i) {
e651a1da442ae02 Srinivas Pandruvada 2015-02-19 @738 struct hid_sensor_hub_device *hsdev =
e651a1da442ae02 Srinivas Pandruvada 2015-02-19 739 data->hid_sensor_hub_client_devs[i].platform_data;
e651a1da442ae02 Srinivas Pandruvada 2015-02-19 740 if (hsdev->pending.status)
e651a1da442ae02 Srinivas Pandruvada 2015-02-19 741 complete(&hsdev->pending.ready);
e651a1da442ae02 Srinivas Pandruvada 2015-02-19 742 }
401ca24fb34aee0 srinivas pandruvada 2012-09-05 743 spin_unlock_irqrestore(&data->lock, flags);
401ca24fb34aee0 srinivas pandruvada 2012-09-05 744 mfd_remove_devices(&hdev->dev);
401ca24fb34aee0 srinivas pandruvada 2012-09-05 745 mutex_destroy(&data->mutex);
401ca24fb34aee0 srinivas pandruvada 2012-09-05 746 }
401ca24fb34aee0 srinivas pandruvada 2012-09-05 747
:::::: The code at line 738 was first introduced by commit
:::::: e651a1da442ae02a50081e38309dea5e89da2d41 HID: hid-sensor-hub: Allow parallel synchronous reads
:::::: TO: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
:::::: CC: Jiri Kosina <jkosina@suse.cz>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33313 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] mfd: mfd_cell: constify platform_data
2020-05-16 13:53 ` kbuild test robot
@ 2020-05-18 8:45 ` Lee Jones
0 siblings, 0 replies; 6+ messages in thread
From: Lee Jones @ 2020-05-18 8:45 UTC (permalink / raw)
To: kbuild test robot
Cc: Tomas Winkler, Andy Shevchenko, Greg Kroah-Hartman, kbuild-all,
clang-built-linux, linux-kernel
On Sat, 16 May 2020, kbuild test robot wrote:
> Hi Tomas,
>
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on ljones-mfd/for-mfd-next]
> [also build test ERROR on v5.7-rc5 next-20200515]
> [if your patch is applied to the wrong git tree, please drop us a note to help
> improve the system. BTW, we also suggest to use '--base' option to specify the
> base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
>
> url: https://github.com/0day-ci/linux/commits/Tomas-Winkler/mfd-constify-pointers/20200516-190733
> base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
> config: arm-randconfig-r006-20200515 (attached as .config)
> compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 13d44b2a0c7ef404b13b16644765977cd5310fe2)
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # install arm cross compiling tool for clang build
> # apt-get install binutils-arm-linux-gnueabi
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kbuild test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>, old ones prefixed by <<):
>
> >> drivers/hid/hid-sensor-hub.c:738:33: error: initializing 'struct hid_sensor_hub_device *' with an expression of type 'const void *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
> struct hid_sensor_hub_device *hsdev =
> ^
Obviously this would need fixing before it can be considered.
> 1 error generated.
>
> vim +738 drivers/hid/hid-sensor-hub.c
>
> 401ca24fb34aee0 srinivas pandruvada 2012-09-05 726
> 401ca24fb34aee0 srinivas pandruvada 2012-09-05 727 static void sensor_hub_remove(struct hid_device *hdev)
> 401ca24fb34aee0 srinivas pandruvada 2012-09-05 728 {
> 401ca24fb34aee0 srinivas pandruvada 2012-09-05 729 struct sensor_hub_data *data = hid_get_drvdata(hdev);
> 401ca24fb34aee0 srinivas pandruvada 2012-09-05 730 unsigned long flags;
> e651a1da442ae02 Srinivas Pandruvada 2015-02-19 731 int i;
> 401ca24fb34aee0 srinivas pandruvada 2012-09-05 732
> 401ca24fb34aee0 srinivas pandruvada 2012-09-05 733 hid_dbg(hdev, " hardware removed\n");
> 401ca24fb34aee0 srinivas pandruvada 2012-09-05 734 hid_hw_close(hdev);
> f2f13a68c37c13a Axel Lin 2012-09-19 735 hid_hw_stop(hdev);
> 401ca24fb34aee0 srinivas pandruvada 2012-09-05 736 spin_lock_irqsave(&data->lock, flags);
> e651a1da442ae02 Srinivas Pandruvada 2015-02-19 737 for (i = 0; i < data->hid_sensor_client_cnt; ++i) {
> e651a1da442ae02 Srinivas Pandruvada 2015-02-19 @738 struct hid_sensor_hub_device *hsdev =
> e651a1da442ae02 Srinivas Pandruvada 2015-02-19 739 data->hid_sensor_hub_client_devs[i].platform_data;
> e651a1da442ae02 Srinivas Pandruvada 2015-02-19 740 if (hsdev->pending.status)
> e651a1da442ae02 Srinivas Pandruvada 2015-02-19 741 complete(&hsdev->pending.ready);
> e651a1da442ae02 Srinivas Pandruvada 2015-02-19 742 }
> 401ca24fb34aee0 srinivas pandruvada 2012-09-05 743 spin_unlock_irqrestore(&data->lock, flags);
> 401ca24fb34aee0 srinivas pandruvada 2012-09-05 744 mfd_remove_devices(&hdev->dev);
> 401ca24fb34aee0 srinivas pandruvada 2012-09-05 745 mutex_destroy(&data->mutex);
> 401ca24fb34aee0 srinivas pandruvada 2012-09-05 746 }
> 401ca24fb34aee0 srinivas pandruvada 2012-09-05 747
>
> :::::: The code at line 738 was first introduced by commit
> :::::: e651a1da442ae02a50081e38309dea5e89da2d41 HID: hid-sensor-hub: Allow parallel synchronous reads
>
> :::::: TO: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> :::::: CC: Jiri Kosina <jkosina@suse.cz>
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-05-20 10:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-16 11:06 [PATCH 0/2] mfd: constify pointers Tomas Winkler
2020-05-16 11:06 ` [PATCH 1/2] mfd: constify properties in mfd_cell Tomas Winkler
2020-05-20 10:50 ` Lee Jones
2020-05-16 11:06 ` [PATCH 2/2] mfd: mfd_cell: constify platform_data Tomas Winkler
2020-05-16 13:53 ` kbuild test robot
2020-05-18 8:45 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox