The Linux Kernel Mailing List
 help / color / mirror / Atom feed
* [for-next][PATCH] tracing: Remove obsolete PREEMPTIRQ_EVENTS kconfig option
@ 2020-06-08 18:31 Steven Rostedt
  0 siblings, 0 replies; only message in thread
From: Steven Rostedt @ 2020-06-08 18:31 UTC (permalink / raw)
  To: LKML; +Cc: Ingo Molnar, Andrew Morton, Mel Gorman

  git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
for-next

Head SHA1: 388d8bdb87e01bcea6d0b2bf797b5f6d7b2401fb


Mel Gorman (1):
      tracing: Remove obsolete PREEMPTIRQ_EVENTS kconfig option

----
 kernel/trace/Kconfig | 9 ---------
 1 file changed, 9 deletions(-)
---------------------------
commit 388d8bdb87e01bcea6d0b2bf797b5f6d7b2401fb
Author: Mel Gorman <mgorman@techsingularity.net>
Date:   Thu Apr 9 11:40:34 2020 +0100

    tracing: Remove obsolete PREEMPTIRQ_EVENTS kconfig option
    
    The PREEMPTIRQ_EVENTS option is unused after commit c3bc8fd637a9 ("tracing:
    Centralize preemptirq tracepoints and unify their usage"). Remove it.
    
    Note that this option is hazardous as it stands. It enables TRACE_IRQFLAGS
    event on non-preempt configurations without the irqsoff tracer enabled.
    TRACE_IRQFLAGS as it stands incurs significant overhead on each IRQ
    entry/exit. This is because trace_hardirqs_[on|off] does all the per-cpu
    manipulations and NMI checks even if tracing is completely disabled for
    some insane reason.  For example, netperf running UDP_STREAM on localhost
    incurs a 4-6% performance penalty without any tracing if IRQFLAGS is
    set. It can be put behind a static brach but even the function entry/exit
    costs a little bit.
    
    Link: https://lkml.kernel.org/r/20200409104034.GJ3818@techsingularity.net
    
    Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
    Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
index 75407d5dc83a..0c82ac2c5688 100644
--- a/kernel/trace/Kconfig
+++ b/kernel/trace/Kconfig
@@ -258,15 +258,6 @@ config TRACE_PREEMPT_TOGGLE
 	  Enables hooks which will be called when preemption is first disabled,
 	  and last enabled.
 
-config PREEMPTIRQ_EVENTS
-	bool "Enable trace events for preempt and irq disable/enable"
-	select TRACE_IRQFLAGS
-	select TRACE_PREEMPT_TOGGLE if PREEMPTION
-	select GENERIC_TRACER
-	default n
-	help
-	  Enable tracing of disable and enable events for preemption and irqs.
-
 config IRQSOFF_TRACER
 	bool "Interrupts-off Latency Tracer"
 	default n

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2020-06-08 18:31 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-08 18:31 [for-next][PATCH] tracing: Remove obsolete PREEMPTIRQ_EVENTS kconfig option Steven Rostedt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox