* [PATCH 0/2] nvme: simple cleanup
@ 2020-06-08 16:20 Dongli Zhang
2020-06-08 16:20 ` [PATCH 1/2] nvmet-loop: remove unused 'target_ctrl' in nvme_loop_ctrl Dongli Zhang
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Dongli Zhang @ 2020-06-08 16:20 UTC (permalink / raw)
To: linux-nvme; +Cc: linux-kernel, hch, sagi, chaitanya.kulkarni, kbusch, axboe
Just cleanup without functional change.
Thank you very much!
Dongli Zhang
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH 1/2] nvmet-loop: remove unused 'target_ctrl' in nvme_loop_ctrl
2020-06-08 16:20 [PATCH 0/2] nvme: simple cleanup Dongli Zhang
@ 2020-06-08 16:20 ` Dongli Zhang
2020-06-08 16:56 ` Sagi Grimberg
2020-06-08 21:34 ` Chaitanya Kulkarni
2020-06-08 16:20 ` [PATCH 2/2] nvme-pci: remove empty line following nvme_should_reset() Dongli Zhang
2020-06-09 13:55 ` [PATCH 0/2] nvme: simple cleanup Christoph Hellwig
2 siblings, 2 replies; 8+ messages in thread
From: Dongli Zhang @ 2020-06-08 16:20 UTC (permalink / raw)
To: linux-nvme; +Cc: linux-kernel, hch, sagi, chaitanya.kulkarni, kbusch, axboe
This field is never used since the introduction of nvme loopback by
commit 3a85a5de29ea ("nvme-loop: add a NVMe loopback host driver").
Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
---
drivers/nvme/target/loop.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/nvme/target/loop.c b/drivers/nvme/target/loop.c
index 0d54e730cbf2..e8fa70c15143 100644
--- a/drivers/nvme/target/loop.c
+++ b/drivers/nvme/target/loop.c
@@ -36,7 +36,6 @@ struct nvme_loop_ctrl {
struct nvme_loop_iod async_event_iod;
struct nvme_ctrl ctrl;
- struct nvmet_ctrl *target_ctrl;
struct nvmet_port *port;
};
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 1/2] nvmet-loop: remove unused 'target_ctrl' in nvme_loop_ctrl
2020-06-08 16:20 ` [PATCH 1/2] nvmet-loop: remove unused 'target_ctrl' in nvme_loop_ctrl Dongli Zhang
@ 2020-06-08 16:56 ` Sagi Grimberg
2020-06-08 21:34 ` Chaitanya Kulkarni
1 sibling, 0 replies; 8+ messages in thread
From: Sagi Grimberg @ 2020-06-08 16:56 UTC (permalink / raw)
To: Dongli Zhang, linux-nvme
Cc: linux-kernel, hch, chaitanya.kulkarni, kbusch, axboe
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] nvmet-loop: remove unused 'target_ctrl' in nvme_loop_ctrl
2020-06-08 16:20 ` [PATCH 1/2] nvmet-loop: remove unused 'target_ctrl' in nvme_loop_ctrl Dongli Zhang
2020-06-08 16:56 ` Sagi Grimberg
@ 2020-06-08 21:34 ` Chaitanya Kulkarni
1 sibling, 0 replies; 8+ messages in thread
From: Chaitanya Kulkarni @ 2020-06-08 21:34 UTC (permalink / raw)
To: Dongli Zhang, linux-nvme@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, hch@lst.de, sagi@grimberg.me,
kbusch@kernel.org, axboe@fb.com
On 6/8/20 9:29 AM, Dongli Zhang wrote:
> This field is never used since the introduction of nvme loopback by
> commit 3a85a5de29ea ("nvme-loop: add a NVMe loopback host driver").
>
> Signed-off-by: Dongli Zhang<dongli.zhang@oracle.com>
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/2] nvme-pci: remove empty line following nvme_should_reset()
2020-06-08 16:20 [PATCH 0/2] nvme: simple cleanup Dongli Zhang
2020-06-08 16:20 ` [PATCH 1/2] nvmet-loop: remove unused 'target_ctrl' in nvme_loop_ctrl Dongli Zhang
@ 2020-06-08 16:20 ` Dongli Zhang
2020-06-08 16:56 ` Sagi Grimberg
2020-06-08 21:34 ` Chaitanya Kulkarni
2020-06-09 13:55 ` [PATCH 0/2] nvme: simple cleanup Christoph Hellwig
2 siblings, 2 replies; 8+ messages in thread
From: Dongli Zhang @ 2020-06-08 16:20 UTC (permalink / raw)
To: linux-nvme; +Cc: linux-kernel, hch, sagi, chaitanya.kulkarni, kbusch, axboe
Just cleanup by removing the empty line.
Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
---
drivers/nvme/host/pci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index d690d5593a80..4471e9910906 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -1153,7 +1153,6 @@ static void abort_endio(struct request *req, blk_status_t error)
static bool nvme_should_reset(struct nvme_dev *dev, u32 csts)
{
-
/* If true, indicates loss of adapter communication, possibly by a
* NVMe Subsystem reset.
*/
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 2/2] nvme-pci: remove empty line following nvme_should_reset()
2020-06-08 16:20 ` [PATCH 2/2] nvme-pci: remove empty line following nvme_should_reset() Dongli Zhang
@ 2020-06-08 16:56 ` Sagi Grimberg
2020-06-08 21:34 ` Chaitanya Kulkarni
1 sibling, 0 replies; 8+ messages in thread
From: Sagi Grimberg @ 2020-06-08 16:56 UTC (permalink / raw)
To: Dongli Zhang, linux-nvme
Cc: linux-kernel, hch, chaitanya.kulkarni, kbusch, axboe
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] nvme-pci: remove empty line following nvme_should_reset()
2020-06-08 16:20 ` [PATCH 2/2] nvme-pci: remove empty line following nvme_should_reset() Dongli Zhang
2020-06-08 16:56 ` Sagi Grimberg
@ 2020-06-08 21:34 ` Chaitanya Kulkarni
1 sibling, 0 replies; 8+ messages in thread
From: Chaitanya Kulkarni @ 2020-06-08 21:34 UTC (permalink / raw)
To: Dongli Zhang, linux-nvme@lists.infradead.org
Cc: sagi@grimberg.me, linux-kernel@vger.kernel.org, axboe@fb.com,
kbusch@kernel.org, hch@lst.de
On 6/8/20 9:29 AM, Dongli Zhang wrote:
> Just cleanup by removing the empty line.
>
> Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
> ---
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 0/2] nvme: simple cleanup
2020-06-08 16:20 [PATCH 0/2] nvme: simple cleanup Dongli Zhang
2020-06-08 16:20 ` [PATCH 1/2] nvmet-loop: remove unused 'target_ctrl' in nvme_loop_ctrl Dongli Zhang
2020-06-08 16:20 ` [PATCH 2/2] nvme-pci: remove empty line following nvme_should_reset() Dongli Zhang
@ 2020-06-09 13:55 ` Christoph Hellwig
2 siblings, 0 replies; 8+ messages in thread
From: Christoph Hellwig @ 2020-06-09 13:55 UTC (permalink / raw)
To: Dongli Zhang
Cc: linux-nvme, linux-kernel, hch, sagi, chaitanya.kulkarni, kbusch,
axboe
Thanks,
applied to nvme-5.9.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-06-09 13:55 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-08 16:20 [PATCH 0/2] nvme: simple cleanup Dongli Zhang
2020-06-08 16:20 ` [PATCH 1/2] nvmet-loop: remove unused 'target_ctrl' in nvme_loop_ctrl Dongli Zhang
2020-06-08 16:56 ` Sagi Grimberg
2020-06-08 21:34 ` Chaitanya Kulkarni
2020-06-08 16:20 ` [PATCH 2/2] nvme-pci: remove empty line following nvme_should_reset() Dongli Zhang
2020-06-08 16:56 ` Sagi Grimberg
2020-06-08 21:34 ` Chaitanya Kulkarni
2020-06-09 13:55 ` [PATCH 0/2] nvme: simple cleanup Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox