public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: x86@kernel.org
Cc: linux-kernel@vger.kernel.org, rostedt@goodmis.org,
	mhiramat@kernel.org, bristot@redhat.com, jbaron@akamai.com,
	torvalds@linux-foundation.org, tglx@linutronix.de,
	mingo@kernel.org, namit@vmware.com, hpa@zytor.com,
	luto@kernel.org, ard.biesheuvel@linaro.org, jpoimboe@redhat.com,
	pbonzini@redhat.com, mathieu.desnoyers@efficios.com,
	linux@rasmusvillemoes.dk
Subject: Re: [PATCH v5 00/17] Add static_call()
Date: Thu, 9 Jul 2020 11:02:10 +0200	[thread overview]
Message-ID: <20200709090210.GL597537@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20200624153024.794671356@infradead.org>

On Wed, Jun 24, 2020 at 05:30:24PM +0200, Peter Zijlstra wrote:
> Hi all,
> 
> Hopefully for the last time...
> 
> static_call(), is the idea of static_branch() applied to indirect function
> calls. Remove a data load (indirection) by modifying the text.
> 
> The inline implementation still relies on objtool to generate the
> .static_call_sites section, mostly because this is a natural place for x86_64
> and works for both GCC and LLVM.  Other architectures can pick other means
> if/when they implement the inline patching. The out-of-line (aka. trampoline)
> variant doesn't require this.
> 
> Patches go on top of tip/objtool/core + tip/perf/core
> 
> Patches can also be found here:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git x86/static_call
> 
> Changes since the last time:
> 
>  - Better documentation
>  - More consistent macro names
>  - Changed key prefix
>  - Folded trampoline definitions
>  - Renamed DEFINE_STATIC_COND_CALL / DEFINE_STATIC_CALL_NULL

v5.1 (patch 16) has a crash fix found by 0day, synthetic tracepoints
don't have static call sites.

Given the overwhelming feedback on this series, I'm thinking everybody
is in violent agreement with the code this time around (or just really
busy, in which case, consider this a gentle prod to send out your ACK
:-).



      parent reply	other threads:[~2020-07-09  9:02 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-24 15:30 [PATCH v5 00/17] Add static_call() Peter Zijlstra
2020-06-24 15:30 ` [PATCH v5 01/17] notifier: Fix broken error handling pattern Peter Zijlstra
2020-06-24 15:30 ` [PATCH v5 02/17] module: Fix up module_notifier return values Peter Zijlstra
2020-06-24 15:30 ` [PATCH v5 03/17] module: Properly propagate MODULE_STATE_COMING failure Peter Zijlstra
2020-06-24 15:30 ` [PATCH v5 04/17] jump_label,module: Fix module lifetime for __jump_label_mod_text_reserved Peter Zijlstra
2020-06-24 15:30 ` [PATCH v5 05/17] compiler.h: Make __ADDRESSABLE() symbol truly unique Peter Zijlstra
2020-06-24 15:30 ` [PATCH v5 06/17] static_call: Add basic static call infrastructure Peter Zijlstra
2020-06-24 15:30 ` [PATCH v5 07/17] static_call: Add inline " Peter Zijlstra
2020-06-24 15:30 ` [PATCH v5 08/17] static_call: Avoid kprobes on inline static_call()s Peter Zijlstra
2020-06-24 15:30 ` [PATCH v5 09/17] x86/static_call: Add out-of-line static call implementation Peter Zijlstra
2020-06-24 15:30 ` [PATCH v5 10/17] x86/static_call: Add inline static call implementation for x86-64 Peter Zijlstra
2020-06-24 15:30 ` [PATCH v5 11/17] static_call: Simple self-test Peter Zijlstra
2020-06-24 15:30 ` [PATCH v5 12/17] x86/alternatives: Teach text_poke_bp() to emulate RET Peter Zijlstra
2020-06-24 15:30 ` [PATCH v5 13/17] static_call: Add static_call_cond() Peter Zijlstra
2020-06-24 15:30 ` [PATCH v5 14/17] static_call: Handle tail-calls Peter Zijlstra
2020-06-24 15:30 ` [PATCH v5 15/17] static_call: Allow early init Peter Zijlstra
2020-06-24 15:30 ` [PATCH v5 16/17] tracepoint: Optimize using static_call() Peter Zijlstra
2020-07-09  8:58   ` [PATCH v5.1 " Peter Zijlstra
2020-06-24 15:30 ` [PATCH v5 17/17] x86/perf, static_call: Optimize x86_pmu methods Peter Zijlstra
2020-07-09 11:16   ` Peter Zijlstra
2020-07-09  9:02 ` Peter Zijlstra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200709090210.GL597537@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=ard.biesheuvel@linaro.org \
    --cc=bristot@redhat.com \
    --cc=hpa@zytor.com \
    --cc=jbaron@akamai.com \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=luto@kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=mingo@kernel.org \
    --cc=namit@vmware.com \
    --cc=pbonzini@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox