* [PATCH] drm/panel: remove meaningless if(ret) check code.
@ 2020-07-22 1:41 Bernard Zhao
0 siblings, 0 replies; 2+ messages in thread
From: Bernard Zhao @ 2020-07-22 1:41 UTC (permalink / raw)
To: Icenowy Zheng, Thierry Reding, Sam Ravnborg, David Airlie,
Daniel Vetter, dri-devel, linux-kernel
Cc: opensource.kernel, Bernard Zhao
The function drm_panel_add always returns true.
So if(ret) check code will never run into error branch.
Remove these check make the code a bit readable.
Signed-off-by: Bernard Zhao <bernard@vivo.com>
---
drivers/gpu/drm/panel/panel-feixin-k101-im2ba02.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-feixin-k101-im2ba02.c b/drivers/gpu/drm/panel/panel-feixin-k101-im2ba02.c
index fddbfddf6566..7f2eb54e4254 100644
--- a/drivers/gpu/drm/panel/panel-feixin-k101-im2ba02.c
+++ b/drivers/gpu/drm/panel/panel-feixin-k101-im2ba02.c
@@ -478,9 +478,7 @@ static int k101_im2ba02_dsi_probe(struct mipi_dsi_device *dsi)
if (ret)
return ret;
- ret = drm_panel_add(&ctx->panel);
- if (ret < 0)
- return ret;
+ drm_panel_add(&ctx->panel);
dsi->mode_flags = MIPI_DSI_MODE_VIDEO;
dsi->format = MIPI_DSI_FMT_RGB888;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] drm/panel: remove meaningless if(ret) check code.
@ 2020-07-22 1:49 Bernard Zhao
0 siblings, 0 replies; 2+ messages in thread
From: Bernard Zhao @ 2020-07-22 1:49 UTC (permalink / raw)
To: Jagan Teki, Thierry Reding, Sam Ravnborg, David Airlie,
Daniel Vetter, dri-devel, linux-kernel
Cc: opensource.kernel, Bernard Zhao
The function drm_panel_add always returns true.
So if(ret) check code will never run into error branch.
Remove these check will make the code a bit readable.
Signed-off-by: Bernard Zhao <bernard@vivo.com>
---
drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c b/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c
index 95b789ab9d29..2c168a405928 100644
--- a/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c
+++ b/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c
@@ -225,9 +225,7 @@ static int feiyang_dsi_probe(struct mipi_dsi_device *dsi)
if (ret)
return ret;
- ret = drm_panel_add(&ctx->panel);
- if (ret < 0)
- return ret;
+ drm_panel_add(&ctx->panel);
dsi->mode_flags = MIPI_DSI_MODE_VIDEO_BURST;
dsi->format = MIPI_DSI_FMT_RGB888;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-22 1:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-22 1:41 [PATCH] drm/panel: remove meaningless if(ret) check code Bernard Zhao
-- strict thread matches above, loose matches on Subject: below --
2020-07-22 1:49 Bernard Zhao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox