* drivers/char/tpm/tpm_ftpm_tee.c:180:8-9: WARNING: return of 0/1 in function 'ftpm_tee_tpm_req_canceled' with return type bool
@ 2020-07-25 8:42 kernel test robot
2020-07-25 8:42 ` [PATCH] tpm/tpm_ftpm_tee: fix boolreturn.cocci warnings kernel test robot
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2020-07-25 8:42 UTC (permalink / raw)
To: Sasha Levin
Cc: kbuild-all, linux-kernel, Jarkko Sakkinen,
Thirupathaiah Annapureddy
[-- Attachment #1: Type: text/plain, Size: 822 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 23ee3e4e5bd27bdbc0f1785eef7209ce872794c7
commit: 09e574831b277a3f77d78ceadd08a3859a84fdb3 tpm/tpm_ftpm_tee: A driver for firmware TPM running inside TEE
date: 11 months ago
config: arm64-randconfig-c023-20200724 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
coccinelle warnings: (new ones prefixed by >>)
>> drivers/char/tpm/tpm_ftpm_tee.c:180:8-9: WARNING: return of 0/1 in function 'ftpm_tee_tpm_req_canceled' with return type bool
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32007 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] tpm/tpm_ftpm_tee: fix boolreturn.cocci warnings
2020-07-25 8:42 drivers/char/tpm/tpm_ftpm_tee.c:180:8-9: WARNING: return of 0/1 in function 'ftpm_tee_tpm_req_canceled' with return type bool kernel test robot
@ 2020-07-25 8:42 ` kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2020-07-25 8:42 UTC (permalink / raw)
To: Sasha Levin
Cc: kbuild-all, linux-kernel, Jarkko Sakkinen,
Thirupathaiah Annapureddy, Peter Huewe, Jason Gunthorpe,
Arnd Bergmann, Greg Kroah-Hartman, linux-integrity
From: kernel test robot <lkp@intel.com>
drivers/char/tpm/tpm_ftpm_tee.c:180:8-9: WARNING: return of 0/1 in function 'ftpm_tee_tpm_req_canceled' with return type bool
Return statements in functions returning bool should use
true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci
Fixes: 09e574831b27 ("tpm/tpm_ftpm_tee: A driver for firmware TPM running inside TEE")
CC: Sasha Levin <sashal@kernel.org>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 23ee3e4e5bd27bdbc0f1785eef7209ce872794c7
commit: 09e574831b277a3f77d78ceadd08a3859a84fdb3 tpm/tpm_ftpm_tee: A driver for firmware TPM running inside TEE
tpm_ftpm_tee.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/char/tpm/tpm_ftpm_tee.c
+++ b/drivers/char/tpm/tpm_ftpm_tee.c
@@ -177,7 +177,7 @@ static u8 ftpm_tee_tpm_op_status(struct
static bool ftpm_tee_tpm_req_canceled(struct tpm_chip *chip, u8 status)
{
- return 0;
+ return false;
}
static const struct tpm_class_ops ftpm_tee_tpm_ops = {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-25 8:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-25 8:42 drivers/char/tpm/tpm_ftpm_tee.c:180:8-9: WARNING: return of 0/1 in function 'ftpm_tee_tpm_req_canceled' with return type bool kernel test robot
2020-07-25 8:42 ` [PATCH] tpm/tpm_ftpm_tee: fix boolreturn.cocci warnings kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox