* [PATCH] vim: linux-kernel: Increase columns highlighting to 100+
@ 2020-07-31 16:33 Gustavo A. R. Silva
2020-07-31 16:35 ` Joe Perches
0 siblings, 1 reply; 5+ messages in thread
From: Gustavo A. R. Silva @ 2020-07-31 16:33 UTC (permalink / raw)
To: Vivien Didelot; +Cc: linux-kernel, Gustavo A. R. Silva
Increase columns highlighting to 100+ once the 80-column warning has
been deprecated in the Linux kernel[1].
[1] commit bdc48fa11e46 ("checkpatch/coding-style: deprecate 80-column warning")
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
plugin/linuxsty.vim | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/plugin/linuxsty.vim b/plugin/linuxsty.vim
index 6f7e331..c42ce72 100644
--- a/plugin/linuxsty.vim
+++ b/plugin/linuxsty.vim
@@ -62,7 +62,7 @@ function s:LinuxFormatting()
setlocal tabstop=8
setlocal shiftwidth=8
setlocal softtabstop=8
- setlocal textwidth=80
+ setlocal textwidth=100
setlocal noexpandtab
setlocal cindent
@@ -80,7 +80,7 @@ function s:LinuxHighlighting()
highlight default link LinuxError ErrorMsg
syn match LinuxError / \+\ze\t/ " spaces before tab
- syn match LinuxError /\%>80v[^()\{\}\[\]<>]\+/ " virtual column 81 and more
+ syn match LinuxError /\%>100v[^()\{\}\[\]<>]\+/ " virtual column 101 and more
" Highlight trailing whitespace, unless we're in insert mode and the
" cursor's placed right after the whitespace. This prevents us from having
--
2.27.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] vim: linux-kernel: Increase columns highlighting to 100+
2020-07-31 16:33 [PATCH] vim: linux-kernel: Increase columns highlighting to 100+ Gustavo A. R. Silva
@ 2020-07-31 16:35 ` Joe Perches
2020-07-31 17:07 ` Gustavo A. R. Silva
0 siblings, 1 reply; 5+ messages in thread
From: Joe Perches @ 2020-07-31 16:35 UTC (permalink / raw)
To: Gustavo A. R. Silva, Vivien Didelot; +Cc: linux-kernel
On Fri, 2020-07-31 at 11:33 -0500, Gustavo A. R. Silva wrote:
> Increase columns highlighting to 100+ once the 80-column warning has
> been deprecated in the Linux kernel[1].
>
> [1] commit bdc48fa11e46 ("checkpatch/coding-style: deprecate 80-column warning")
>
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> plugin/linuxsty.vim | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/plugin/linuxsty.vim b/plugin/linuxsty.vim
> index 6f7e331..c42ce72 100644
> --- a/plugin/linuxsty.vim
> +++ b/plugin/linuxsty.vim
> @@ -62,7 +62,7 @@ function s:LinuxFormatting()
> setlocal tabstop=8
> setlocal shiftwidth=8
> setlocal softtabstop=8
> - setlocal textwidth=80
> + setlocal textwidth=100
This is not a good change.
80 columns is still _preferred_.
It's just checkpatch will not emit a warning
for lines longer than 80 columns but will
for lines longer than 100 columns.
checkpatch will also not emit a warning on
file checking at all.
> setlocal noexpandtab
>
> setlocal cindent
> @@ -80,7 +80,7 @@ function s:LinuxHighlighting()
> highlight default link LinuxError ErrorMsg
>
> syn match LinuxError / \+\ze\t/ " spaces before tab
> - syn match LinuxError /\%>80v[^()\{\}\[\]<>]\+/ " virtual column 81 and more
> + syn match LinuxError /\%>100v[^()\{\}\[\]<>]\+/ " virtual column 101 and more
>
> " Highlight trailing whitespace, unless we're in insert mode and the
> " cursor's placed right after the whitespace. This prevents us from having
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] vim: linux-kernel: Increase columns highlighting to 100+
2020-07-31 16:35 ` Joe Perches
@ 2020-07-31 17:07 ` Gustavo A. R. Silva
2020-07-31 17:17 ` Joe Perches
0 siblings, 1 reply; 5+ messages in thread
From: Gustavo A. R. Silva @ 2020-07-31 17:07 UTC (permalink / raw)
To: Joe Perches; +Cc: Vivien Didelot, linux-kernel
On Fri, Jul 31, 2020 at 09:35:42AM -0700, Joe Perches wrote:
> On Fri, 2020-07-31 at 11:33 -0500, Gustavo A. R. Silva wrote:
> > Increase columns highlighting to 100+ once the 80-column warning has
> > been deprecated in the Linux kernel[1].
> >
> > [1] commit bdc48fa11e46 ("checkpatch/coding-style: deprecate 80-column warning")
> >
> > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> > ---
> > plugin/linuxsty.vim | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/plugin/linuxsty.vim b/plugin/linuxsty.vim
> > index 6f7e331..c42ce72 100644
> > --- a/plugin/linuxsty.vim
> > +++ b/plugin/linuxsty.vim
> > @@ -62,7 +62,7 @@ function s:LinuxFormatting()
> > setlocal tabstop=8
> > setlocal shiftwidth=8
> > setlocal softtabstop=8
> > - setlocal textwidth=80
> > + setlocal textwidth=100
>
> This is not a good change.
> 80 columns is still _preferred_.
>
Now that you mention that, I have mixed feelings about this.
Let's see if we can get more opinions...
--
Gustavo
>
> > setlocal noexpandtab
> >
> > setlocal cindent
> > @@ -80,7 +80,7 @@ function s:LinuxHighlighting()
> > highlight default link LinuxError ErrorMsg
> >
> > syn match LinuxError / \+\ze\t/ " spaces before tab
> > - syn match LinuxError /\%>80v[^()\{\}\[\]<>]\+/ " virtual column 81 and more
> > + syn match LinuxError /\%>100v[^()\{\}\[\]<>]\+/ " virtual column 101 and more
> >
> > " Highlight trailing whitespace, unless we're in insert mode and the
> > " cursor's placed right after the whitespace. This prevents us from having
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] vim: linux-kernel: Increase columns highlighting to 100+
2020-07-31 17:07 ` Gustavo A. R. Silva
@ 2020-07-31 17:17 ` Joe Perches
0 siblings, 0 replies; 5+ messages in thread
From: Joe Perches @ 2020-07-31 17:17 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: Vivien Didelot, linux-kernel
On Fri, 2020-07-31 at 12:07 -0500, Gustavo A. R. Silva wrote:
> On Fri, Jul 31, 2020 at 09:35:42AM -0700, Joe Perches wrote:
> > On Fri, 2020-07-31 at 11:33 -0500, Gustavo A. R. Silva wrote:
> > > Increase columns highlighting to 100+ once the 80-column warning has
> > > been deprecated in the Linux kernel[1].
> > >
> > > [1] commit bdc48fa11e46 ("checkpatch/coding-style: deprecate 80-column warning")
> > >
> > > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> > > ---
> > > plugin/linuxsty.vim | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/plugin/linuxsty.vim b/plugin/linuxsty.vim
> > > index 6f7e331..c42ce72 100644
> > > --- a/plugin/linuxsty.vim
> > > +++ b/plugin/linuxsty.vim
> > > @@ -62,7 +62,7 @@ function s:LinuxFormatting()
> > > setlocal tabstop=8
> > > setlocal shiftwidth=8
> > > setlocal softtabstop=8
> > > - setlocal textwidth=80
> > > + setlocal textwidth=100
> >
> > This is not a good change.
> > 80 columns is still _preferred_.
> >
>
> Now that you mention that, I have mixed feelings about this.
> Let's see if we can get more opinions...
I am not a vim user, but maybe remove this line
altogether and add something like
setlocal colorcolumn=80,100
and let people make their own wrapping decisions.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] vim: linux-kernel: Increase columns highlighting to 100+
@ 2020-07-31 16:30 Gustavo A. R. Silva
0 siblings, 0 replies; 5+ messages in thread
From: Gustavo A. R. Silva @ 2020-07-31 16:30 UTC (permalink / raw)
To: Vivien Didelot; +Cc: linux-kernel, Gustavo A. R. Silva
Increase columns highlighting to 100+ once the 80-column warning has
been deprecated in the Linux kernel[1].
[1] commit bdc48fa11e46 ("checkpatch/coding-style: deprecate 80-column warning")
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
plugin/linuxsty.vim | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/plugin/linuxsty.vim b/plugin/linuxsty.vim
index 6f7e331..c42ce72 100644
--- a/plugin/linuxsty.vim
+++ b/plugin/linuxsty.vim
@@ -62,7 +62,7 @@ function s:LinuxFormatting()
setlocal tabstop=8
setlocal shiftwidth=8
setlocal softtabstop=8
- setlocal textwidth=80
+ setlocal textwidth=100
setlocal noexpandtab
setlocal cindent
@@ -80,7 +80,7 @@ function s:LinuxHighlighting()
highlight default link LinuxError ErrorMsg
syn match LinuxError / \+\ze\t/ " spaces before tab
- syn match LinuxError /\%>80v[^()\{\}\[\]<>]\+/ " virtual column 81 and more
+ syn match LinuxError /\%>100v[^()\{\}\[\]<>]\+/ " virtual column 101 and more
" Highlight trailing whitespace, unless we're in insert mode and the
" cursor's placed right after the whitespace. This prevents us from having
--
2.27.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-07-31 17:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-31 16:33 [PATCH] vim: linux-kernel: Increase columns highlighting to 100+ Gustavo A. R. Silva
2020-07-31 16:35 ` Joe Perches
2020-07-31 17:07 ` Gustavo A. R. Silva
2020-07-31 17:17 ` Joe Perches
-- strict thread matches above, loose matches on Subject: below --
2020-07-31 16:30 Gustavo A. R. Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox