* fs/init.c:72:8: warning: Variable 'error' is reassigned a value before the old one has been used.
@ 2020-08-08 3:35 kernel test robot
2020-08-08 5:40 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2020-08-08 3:35 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: kbuild-all, linux-kernel
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 30185b69a2d533c4ba6ca926b8390ce7de495e29
commit: 4b7ca5014cbef51cdb99fd644eae4f3773747a05 init: add an init_chroot helper
date: 8 days ago
compiler: hppa-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
cppcheck warnings: (new ones prefixed by >>)
>> fs/init.c:72:8: warning: Variable 'error' is reassigned a value before the old one has been used. [redundantAssignment]
error = security_path_chroot(&path);
^
fs/init.c:69:8: note: Variable 'error' is reassigned a value before the old one has been used.
error = -EPERM;
^
fs/init.c:72:8: note: Variable 'error' is reassigned a value before the old one has been used.
error = security_path_chroot(&path);
^
vim +/error +72 fs/init.c
57
58 int __init init_chroot(const char *filename)
59 {
60 struct path path;
61 int error;
62
63 error = kern_path(filename, LOOKUP_FOLLOW | LOOKUP_DIRECTORY, &path);
64 if (error)
65 return error;
66 error = inode_permission(path.dentry->d_inode, MAY_EXEC | MAY_CHDIR);
67 if (error)
68 goto dput_and_out;
69 error = -EPERM;
70 if (!ns_capable(current_user_ns(), CAP_SYS_CHROOT))
71 goto dput_and_out;
> 72 error = security_path_chroot(&path);
73 if (error)
74 goto dput_and_out;
75 set_fs_root(current->fs, &path);
76 dput_and_out:
77 path_put(&path);
78 return error;
79 }
80
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: fs/init.c:72:8: warning: Variable 'error' is reassigned a value before the old one has been used.
2020-08-08 3:35 fs/init.c:72:8: warning: Variable 'error' is reassigned a value before the old one has been used kernel test robot
@ 2020-08-08 5:40 ` Christoph Hellwig
2020-08-10 9:28 ` [kbuild-all] " Xia, Hui
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2020-08-08 5:40 UTC (permalink / raw)
To: kernel test robot; +Cc: Christoph Hellwig, kbuild-all, linux-kernel, viro
On Sat, Aug 08, 2020 at 11:35:45AM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 30185b69a2d533c4ba6ca926b8390ce7de495e29
> commit: 4b7ca5014cbef51cdb99fd644eae4f3773747a05 init: add an init_chroot helper
> date: 8 days ago
> compiler: hppa-linux-gcc (GCC) 9.3.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
>
> cppcheck warnings: (new ones prefixed by >>)
>
> >> fs/init.c:72:8: warning: Variable 'error' is reassigned a value before the old one has been used. [redundantAssignment]
> error = security_path_chroot(&path);
> ^
> fs/init.c:69:8: note: Variable 'error' is reassigned a value before the old one has been used.
> error = -EPERM;
> ^
> fs/init.c:72:8: note: Variable 'error' is reassigned a value before the old one has been used.
> error = security_path_chroot(&path);
I really don't understand the warning. We assign a value to error, if
there is an error we jump the out labe and return it, or else continue.
That is a pretty common pattern in the kernel. What do I miss?
>
> vim +/error +72 fs/init.c
>
> 57
> 58 int __init init_chroot(const char *filename)
> 59 {
> 60 struct path path;
> 61 int error;
> 62
> 63 error = kern_path(filename, LOOKUP_FOLLOW | LOOKUP_DIRECTORY, &path);
> 64 if (error)
> 65 return error;
> 66 error = inode_permission(path.dentry->d_inode, MAY_EXEC | MAY_CHDIR);
> 67 if (error)
> 68 goto dput_and_out;
> 69 error = -EPERM;
> 70 if (!ns_capable(current_user_ns(), CAP_SYS_CHROOT))
> 71 goto dput_and_out;
> > 72 error = security_path_chroot(&path);
> 73 if (error)
> 74 goto dput_and_out;
> 75 set_fs_root(current->fs, &path);
> 76 dput_and_out:
> 77 path_put(&path);
> 78 return error;
> 79 }
> 80
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
---end quoted text---
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [kbuild-all] Re: fs/init.c:72:8: warning: Variable 'error' is reassigned a value before the old one has been used.
2020-08-08 5:40 ` Christoph Hellwig
@ 2020-08-10 9:28 ` Xia, Hui
0 siblings, 0 replies; 3+ messages in thread
From: Xia, Hui @ 2020-08-10 9:28 UTC (permalink / raw)
To: Christoph Hellwig, lkp
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
viro@zeniv.linux.org.uk
>-----Original Message-----
>From: Christoph Hellwig <hch@lst.de>
>Sent: 2020年8月8日 13:40
>To: kernel test robot <lkp@intel.com>
>Cc: Christoph Hellwig <hch@lst.de>; kbuild-all@lists.01.org; linux-
>kernel@vger.kernel.org; viro@zeniv.linux.org.uk
>Subject: [kbuild-all] Re: fs/init.c:72:8: warning: Variable 'error' is reassigned a
>value before the old one has been used.
>
>On Sat, Aug 08, 2020 at 11:35:45AM +0800, kernel test robot wrote:
>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>> head: 30185b69a2d533c4ba6ca926b8390ce7de495e29
>> commit: 4b7ca5014cbef51cdb99fd644eae4f3773747a05 init: add an init_chroot
>helper
>> date: 8 days ago
>> compiler: hppa-linux-gcc (GCC) 9.3.0
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@intel.com>
>>
>>
>> cppcheck warnings: (new ones prefixed by >>)
>>
>> >> fs/init.c:72:8: warning: Variable 'error' is reassigned a value
>> >> before the old one has been used. [redundantAssignment]
>> error = security_path_chroot(&path);
>> ^
>> fs/init.c:69:8: note: Variable 'error' is reassigned a value before the old one
>has been used.
>> error = -EPERM;
>> ^
>> fs/init.c:72:8: note: Variable 'error' is reassigned a value before the old one
>has been used.
>> error = security_path_chroot(&path);
>
>I really don't understand the warning. We assign a value to error, if there is an
>error we jump the out labe and return it, or else continue.
>
>That is a pretty common pattern in the kernel. What do I miss?
Please ignore this report. It is false positive.
We will double check this type of warning in future. Sorry for inconvenient.
Thanks,
Hui
>
>>
>> vim +/error +72 fs/init.c
>>
>> 57
>> 58 int __init init_chroot(const char *filename)
>> 59 {
>> 60 struct path path;
>> 61 int error;
>> 62
>> 63 error = kern_path(filename, LOOKUP_FOLLOW |
>LOOKUP_DIRECTORY, &path);
>> 64 if (error)
>> 65 return error;
>> 66 error = inode_permission(path.dentry->d_inode, MAY_EXEC |
>MAY_CHDIR);
>> 67 if (error)
>> 68 goto dput_and_out;
>> 69 error = -EPERM;
>> 70 if (!ns_capable(current_user_ns(), CAP_SYS_CHROOT))
>> 71 goto dput_and_out;
>> > 72 error = security_path_chroot(&path);
>> 73 if (error)
>> 74 goto dput_and_out;
>> 75 set_fs_root(current->fs, &path);
>> 76 dput_and_out:
>> 77 path_put(&path);
>> 78 return error;
>> 79 }
>> 80
>>
>> ---
>> 0-DAY CI Kernel Test Service, Intel Corporation
>> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
>---end quoted text---
>_______________________________________________
>kbuild-all mailing list -- kbuild-all@lists.01.org To unsubscribe send an email to
>kbuild-all-leave@lists.01.org
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-10 9:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-08 3:35 fs/init.c:72:8: warning: Variable 'error' is reassigned a value before the old one has been used kernel test robot
2020-08-08 5:40 ` Christoph Hellwig
2020-08-10 9:28 ` [kbuild-all] " Xia, Hui
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox