From: Peter Enderborg <peter.enderborg@sony.com>
To: <linux-kernel@vger.kernel.org>,
SElinux list <selinux@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Stephen Smalley <stephen.smalley.work@gmail.com>,
Paul Moore <paul@paul-moore.com>
Cc: Peter Enderborg <peter.enderborg@sony.com>
Subject: [RFC PATCH] selinux: Add denied trace with permssion filter
Date: Mon, 24 Aug 2020 15:22:52 +0200 [thread overview]
Message-ID: <20200824132252.31261-2-peter.enderborg@sony.com> (raw)
In-Reply-To: <20200824132252.31261-1-peter.enderborg@sony.com>
This adds tracing of all denies. They are grouped with trace_seq for
each audit.
A filter can be inserted with a write to it's filter section.
echo "permission==\"entrypoint\"" > events/avc/selinux_denied/filter
A output will be like:
runcon-1046 [002] .N.. 156.351738: selinux_denied:
trace_seq=2 result=-13
scontext=system_u:system_r:cupsd_t:s0-s0:c0.
c1023 tcontext=system_u:object_r:bin_t:s0
tclass=file permission=entrypoint
Signed-off-by: Peter Enderborg <peter.enderborg@sony.com>
---
include/trace/events/avc.h | 37 +++++++++++++++++++++++++++++++++++++
security/selinux/avc.c | 27 +++++++++++++++++++++++++--
2 files changed, 62 insertions(+), 2 deletions(-)
diff --git a/include/trace/events/avc.h b/include/trace/events/avc.h
index 94bca8bef8d2..9a28559956de 100644
--- a/include/trace/events/avc.h
+++ b/include/trace/events/avc.h
@@ -54,6 +54,43 @@ TRACE_EVENT(selinux_audited,
)
);
+TRACE_EVENT(selinux_denied,
+
+ TP_PROTO(struct selinux_audit_data *sad,
+ char *scontext,
+ char *tcontext,
+ const char *tclass,
+ const char *permission,
+ int64_t seq
+ ),
+
+ TP_ARGS(sad, scontext, tcontext, tclass, permission, seq),
+
+ TP_STRUCT__entry(
+ __field(int, result)
+ __string(scontext, scontext)
+ __string(tcontext, tcontext)
+ __string(permission, permission)
+ __string(tclass, tclass)
+ __field(u64, seq)
+ ),
+
+ TP_fast_assign(
+ __entry->result = sad->result;
+ __entry->seq = seq;
+ __assign_str(tcontext, tcontext);
+ __assign_str(scontext, scontext);
+ __assign_str(permission, permission);
+ __assign_str(tclass, tclass);
+ ),
+
+ TP_printk("trace_seq=%lld result=%d scontext=%s tcontext=%s tclass=%s permission=%s",
+ __entry->seq, __entry->result, __get_str(scontext), __get_str(tcontext),
+ __get_str(tclass), __get_str(permission)
+
+ )
+);
+
#endif
/* This part must be outside protection */
diff --git a/security/selinux/avc.c b/security/selinux/avc.c
index 1debddfb5af9..ca53baca15e1 100644
--- a/security/selinux/avc.c
+++ b/security/selinux/avc.c
@@ -92,6 +92,7 @@ struct selinux_avc {
};
static struct selinux_avc selinux_avc;
+static atomic64_t trace_seqno;
void selinux_avc_init(struct selinux_avc **avc)
{
@@ -731,9 +732,31 @@ static void avc_audit_post_callback(struct audit_buffer *ab, void *a)
tclass = secclass_map[sad->tclass-1].name;
audit_log_format(ab, " tclass=%s", tclass);
- if (sad->denied)
+ if (sad->denied) {
audit_log_format(ab, " permissive=%u", sad->result ? 0 : 1);
-
+ if (trace_selinux_denied_enabled()) {
+ int i, perm;
+ const char **perms;
+ u32 denied = sad->denied;
+ int64_t seq;
+
+ seq = atomic_long_inc_return(&trace_seqno);
+ perms = secclass_map[sad->tclass-1].perms;
+ i = 0;
+ perm = 1;
+ while (i < (sizeof(denied) * 8)) {
+ if ((perm & denied & sad->requested) && perms[i]) {
+ trace_selinux_denied(sad, scontext, tcontext,
+ tclass, perms[i], seq);
+ denied &= ~perm;
+ if (!denied)
+ break;
+ }
+ i++;
+ perm <<= 1;
+ }
+ }
+ }
trace_selinux_audited(sad, scontext, tcontext, tclass);
kfree(tcontext);
kfree(scontext);
--
2.17.1
next prev parent reply other threads:[~2020-08-24 13:24 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 17:07 [PATCH v3 0/3] selinux: add detailed tracepoint on audited events Thiébaud Weksteen
2020-08-17 17:07 ` [PATCH v3 1/3] selinux: add " Thiébaud Weksteen
2020-08-18 14:31 ` Stephen Smalley
2020-08-17 17:07 ` [PATCH v3 2/3] selinux: add basic filtering for audit trace events Thiébaud Weksteen
2020-08-18 14:36 ` Stephen Smalley
2020-08-17 17:07 ` [PATCH v3 3/3] selinux: add permission names to trace event Thiébaud Weksteen
2020-08-17 20:13 ` Stephen Smalley
2020-08-17 20:29 ` Steven Rostedt
2020-08-18 16:09 ` Steven Rostedt
2020-08-19 13:11 ` Stephen Smalley
2020-08-21 2:31 ` Steven Rostedt
2020-08-21 12:29 ` Stephen Smalley
2020-08-21 13:19 ` Paul Moore
2020-08-21 13:39 ` peter enderborg
[not found] ` <CA+zpnLfNjDwxgoG2p3W8YfXxYVQDum4Eh_MJQvKP4rGLqsqACA@mail.gmail.com>
2020-08-21 13:46 ` Paul Moore
2020-08-17 20:16 ` Stephen Smalley
2020-08-18 8:11 ` peter enderborg
2020-08-18 12:13 ` Stephen Smalley
2020-08-21 2:22 ` Paul Moore
2020-08-21 5:53 ` peter enderborg
2020-08-21 12:14 ` Stephen Smalley
2020-08-21 13:10 ` Paul Moore
[not found] ` <20200824132252.31261-1-peter.enderborg@sony.com>
2020-08-24 13:22 ` Peter Enderborg [this message]
2020-08-26 13:42 ` [RFC PATCH] selinux: Add denied trace with permssion filter Paul Moore
2020-08-26 14:34 ` peter enderborg
2020-08-26 14:45 ` Paul Moore
2020-08-26 15:06 ` peter enderborg
2020-08-27 13:30 ` Paul Moore
2020-08-27 14:04 ` peter enderborg
2020-08-31 14:16 ` Paul Moore
2020-08-31 14:19 ` Robert Judy
2020-08-31 14:24 ` Paul Moore
2020-08-31 15:34 ` peter enderborg
2020-09-01 15:31 ` Paul Moore
2020-09-01 17:18 ` peter enderborg
2020-09-18 1:47 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824132252.31261-2-peter.enderborg@sony.com \
--to=peter.enderborg@sony.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=rostedt@goodmis.org \
--cc=selinux@vger.kernel.org \
--cc=stephen.smalley.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox