* [PATCH] ASoC: AMD: Clean kernel log from deferred probe error messages
@ 2020-08-26 11:18 Akshu Agrawal
2020-08-26 11:24 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Akshu Agrawal @ 2020-08-26 11:18 UTC (permalink / raw)
To: akshu.agrawal
Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Ravulapati Vishnu vardhan rao, Kuninori Morimoto, YueHaibing,
moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,
open list
While the driver waits for DAIs to be probed and retries probing,
avoid printing error messages.
Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com>
---
sound/soc/amd/acp3x-rt5682-max9836.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/sound/soc/amd/acp3x-rt5682-max9836.c b/sound/soc/amd/acp3x-rt5682-max9836.c
index 406526e79af3..67f80ba51de0 100644
--- a/sound/soc/amd/acp3x-rt5682-max9836.c
+++ b/sound/soc/amd/acp3x-rt5682-max9836.c
@@ -471,13 +471,11 @@ static int acp3x_probe(struct platform_device *pdev)
}
ret = devm_snd_soc_register_card(&pdev->dev, card);
- if (ret) {
+ if (ret && ret != -EPROBE_DEFER)
dev_err(&pdev->dev,
"devm_snd_soc_register_card(%s) failed: %d\n",
card->name, ret);
- return ret;
- }
- return 0;
+ return ret;
}
static const struct acpi_device_id acp3x_audio_acpi_match[] = {
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ASoC: AMD: Clean kernel log from deferred probe error messages
2020-08-26 11:18 [PATCH] ASoC: AMD: Clean kernel log from deferred probe error messages Akshu Agrawal
@ 2020-08-26 11:24 ` Mark Brown
2020-08-26 18:37 ` Agrawal, Akshu
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2020-08-26 11:24 UTC (permalink / raw)
To: Akshu Agrawal
Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
Ravulapati Vishnu vardhan rao, Kuninori Morimoto, YueHaibing,
moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,
open list
[-- Attachment #1: Type: text/plain, Size: 308 bytes --]
On Wed, Aug 26, 2020 at 04:48:05PM +0530, Akshu Agrawal wrote:
> While the driver waits for DAIs to be probed and retries probing,
> avoid printing error messages.
This means that if there is a problem with deferred probe no diagnostics
will be available, there should be something at least at debug level.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: AMD: Clean kernel log from deferred probe error messages
2020-08-26 11:24 ` Mark Brown
@ 2020-08-26 18:37 ` Agrawal, Akshu
0 siblings, 0 replies; 3+ messages in thread
From: Agrawal, Akshu @ 2020-08-26 18:37 UTC (permalink / raw)
To: Mark Brown, Akshu Agrawal
Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
Ravulapati Vishnu vardhan rao, Kuninori Morimoto, YueHaibing,
moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM...,
open list
On 8/26/2020 4:54 PM, Mark Brown wrote:
> On Wed, Aug 26, 2020 at 04:48:05PM +0530, Akshu Agrawal wrote:
>> While the driver waits for DAIs to be probed and retries probing,
>> avoid printing error messages.
> This means that if there is a problem with deferred probe no diagnostics
> will be available, there should be something at least at debug level.
Sure will add a message at debug level for deferred probe.
Thanks,
Akshu
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-26 18:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-26 11:18 [PATCH] ASoC: AMD: Clean kernel log from deferred probe error messages Akshu Agrawal
2020-08-26 11:24 ` Mark Brown
2020-08-26 18:37 ` Agrawal, Akshu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox