* [PATCH] bus: arm-integrator-lm: Add of_node_put() before return statement
@ 2020-08-29 17:41 Sumera Priyadarsini
2020-09-12 10:10 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Sumera Priyadarsini @ 2020-08-29 17:41 UTC (permalink / raw)
To: linus.walleij; +Cc: Julia.Lawall, linux-arm-kernel, linux-kernel
Every iteration of for_each_available_child_of_node() decrements
the reference count of the previous node, however when control is
transferred from the middle of the loop, as in the case of a return
or break or goto, there is no decrement thus ultimately resulting in
a memory leak.
Fix a potential memory leak in arm-integrator-lm.c by inserting
of_node_put() before a return statement.
Issue found with Coccinelle.
Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
---
drivers/bus/arm-integrator-lm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/bus/arm-integrator-lm.c b/drivers/bus/arm-integrator-lm.c
index 845b6c43fef8..2344d560b144 100644
--- a/drivers/bus/arm-integrator-lm.c
+++ b/drivers/bus/arm-integrator-lm.c
@@ -54,6 +54,7 @@ static int integrator_lm_populate(int num, struct device *dev)
ret = of_platform_default_populate(child, NULL, dev);
if (ret) {
dev_err(dev, "failed to populate module\n");
+ of_node_put(child);
return ret;
}
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] bus: arm-integrator-lm: Add of_node_put() before return statement
2020-08-29 17:41 [PATCH] bus: arm-integrator-lm: Add of_node_put() before return statement Sumera Priyadarsini
@ 2020-09-12 10:10 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2020-09-12 10:10 UTC (permalink / raw)
To: Sumera Priyadarsini; +Cc: Julia Lawall, Linux ARM, linux-kernel@vger.kernel.org
On Sat, Aug 29, 2020 at 7:42 PM Sumera Priyadarsini
<sylphrenadin@gmail.com> wrote:
> Every iteration of for_each_available_child_of_node() decrements
> the reference count of the previous node, however when control is
> transferred from the middle of the loop, as in the case of a return
> or break or goto, there is no decrement thus ultimately resulting in
> a memory leak.
>
> Fix a potential memory leak in arm-integrator-lm.c by inserting
> of_node_put() before a return statement.
>
> Issue found with Coccinelle.
>
> Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
Patch applied.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-12 10:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-29 17:41 [PATCH] bus: arm-integrator-lm: Add of_node_put() before return statement Sumera Priyadarsini
2020-09-12 10:10 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox