[PATCH] infiniband: remove unnecessary fallthrough usage

[PATCH] infiniband: remove unnecessary fallthrough usage

[Cengiz Can]

Since /* fallthrough */ comments are deprecated[1], they are being replaced
by new 'fallthrough' pseudo-keyword.

[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?\
        highlight=fallthrough#implicit-switch-case-fall-through

This sometimes leads to unreachable code warnings by static analyzers,
particularly in this case, Coverity Scanner. (CID 1466512)

Remove unnecessary 'fallthrough' keywords to prevent dead code
warnings.

Signed-off-by: Cengiz Can <cengiz@kernel.wtf>
---
 drivers/infiniband/hw/qib/qib_mad.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/infiniband/hw/qib/qib_mad.c b/drivers/infiniband/hw/qib/qib_mad.c
index e7789e724f56..f972e559a8a7 100644
--- a/drivers/infiniband/hw/qib/qib_mad.c
+++ b/drivers/infiniband/hw/qib/qib_mad.c
@@ -2322,7 +2322,6 @@ static int process_cc(struct ib_device *ibdev, int mad_flags,
 			ret = cc_get_congestion_control_table(ccp, ibdev, port);
 			goto bail;
 
-			fallthrough;
 		default:
 			ccp->status |= IB_SMP_UNSUP_METH_ATTR;
 			ret = reply((struct ib_smp *) ccp);
@@ -2339,7 +2338,6 @@ static int process_cc(struct ib_device *ibdev, int mad_flags,
 			ret = cc_set_congestion_control_table(ccp, ibdev, port);
 			goto bail;
 
-			fallthrough;
 		default:
 			ccp->status |= IB_SMP_UNSUP_METH_ATTR;
 			ret = reply((struct ib_smp *) ccp);
-- 
2.28.0

Re: [PATCH] infiniband: remove unnecessary fallthrough usage

[Jason Gunthorpe]

On Mon, Aug 31, 2020 at 06:30:34PM +0300, Cengiz Can wrote:
> Since /* fallthrough */ comments are deprecated[1], they are being replaced
> by new 'fallthrough' pseudo-keyword.
> 
> [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?\
>         highlight=fallthrough#implicit-switch-case-fall-through
> 
> This sometimes leads to unreachable code warnings by static analyzers,
> particularly in this case, Coverity Scanner. (CID 1466512)
> 
> Remove unnecessary 'fallthrough' keywords to prevent dead code
> warnings.
> 
> Signed-off-by: Cengiz Can <cengiz@kernel.wtf>
> ---
>  drivers/infiniband/hw/qib/qib_mad.c | 2 --
>  1 file changed, 2 deletions(-)

Alex beat you to it:

https://patchwork.kernel.org/patch/11736039/

Thanks,
Jason

Re: [PATCH] infiniband: remove unnecessary fallthrough usage

[Cengiz Can]

On 2020-08-31 18:34, Jason Gunthorpe wrote:
> On Mon, Aug 31, 2020 at 06:30:34PM +0300, Cengiz Can wrote:
>> Since /* fallthrough */ comments are deprecated[1], they are being 
>> replaced
>> by new 'fallthrough' pseudo-keyword.
>> 
>> [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?\
>>         highlight=fallthrough#implicit-switch-case-fall-through
>> 
>> This sometimes leads to unreachable code warnings by static analyzers,
>> particularly in this case, Coverity Scanner. (CID 1466512)
>> 
>> Remove unnecessary 'fallthrough' keywords to prevent dead code
>> warnings.
>> 
>> Signed-off-by: Cengiz Can <cengiz@kernel.wtf>
>> ---
>>  drivers/infiniband/hw/qib/qib_mad.c | 2 --
>>  1 file changed, 2 deletions(-)
> 
> Alex beat you to it:
> 
> https://patchwork.kernel.org/patch/11736039/

Well, I'm glad it's fixed :)

Thanks for sharing

> 
> Thanks,
> Jason

-- 
Cengiz Can
@cengiz_io