public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] cgroup: remove redundant kernfs_activate in cgroup_setup_root()
@ 2020-09-25  9:11 Wei Yang
  2020-09-30 16:03 ` Tejun Heo
  0 siblings, 1 reply; 2+ messages in thread
From: Wei Yang @ 2020-09-25  9:11 UTC (permalink / raw)
  To: tj, lizefan, hannes; +Cc: cgroups, linux-kernel, Wei Yang

This step is already done in rebind_subsystems().

Not necessary to do it again.

Signed-off-by: Wei Yang <richard.weiyang@linux.alibaba.com>
---
 kernel/cgroup/cgroup.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
index dd247747ec14..809b13588124 100644
--- a/kernel/cgroup/cgroup.c
+++ b/kernel/cgroup/cgroup.c
@@ -2006,7 +2006,6 @@ int cgroup_setup_root(struct cgroup_root *root, u16 ss_mask)
 	BUG_ON(!list_empty(&root_cgrp->self.children));
 	BUG_ON(atomic_read(&root->nr_cgrps) != 1);
 
-	kernfs_activate(root_cgrp->kn);
 	ret = 0;
 	goto out;
 
-- 
2.20.1 (Apple Git-117)


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] cgroup: remove redundant kernfs_activate in cgroup_setup_root()
  2020-09-25  9:11 [PATCH] cgroup: remove redundant kernfs_activate in cgroup_setup_root() Wei Yang
@ 2020-09-30 16:03 ` Tejun Heo
  0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2020-09-30 16:03 UTC (permalink / raw)
  To: Wei Yang; +Cc: lizefan, hannes, cgroups, linux-kernel

On Fri, Sep 25, 2020 at 05:11:10PM +0800, Wei Yang wrote:
> This step is already done in rebind_subsystems().
> 
> Not necessary to do it again.
> 
> Signed-off-by: Wei Yang <richard.weiyang@linux.alibaba.com>

Applied to cgroup/for-5.10.

Thanks.

-- 
tejun

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-09-30 16:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-25  9:11 [PATCH] cgroup: remove redundant kernfs_activate in cgroup_setup_root() Wei Yang
2020-09-30 16:03 ` Tejun Heo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox