From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Richard Weinberger <richard.weinberger@gmail.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Richard Weinberger <richard@nod.at>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Linus Walleij <linus.walleij@linaro.org>,
Nick Hu <nickhu@andestech.com>, Greentime Hu <green.hu@gmail.com>,
Vincent Chen <deanbo422@gmail.com>
Subject: Re: Build regressions/improvements in v5.9-rc8
Date: Wed, 7 Oct 2020 16:02:41 +0300 [thread overview]
Message-ID: <20201007130241.GA4077@smile.fi.intel.com> (raw)
In-Reply-To: <5f5c303d30eaa32c21131502cc6f28db9d655329.camel@tiscali.nl>
On Wed, Oct 07, 2020 at 02:45:30PM +0200, Paul Bolle wrote:
> Richard Weinberger schreef op wo 07-10-2020 om 14:08 [+0200]:
> > UML has no ia32 emulation and therefore no in_ia32_syscall().
> > Maybe you can check for CONFIG_IA32_EMULATION too?
>
> The pending fix is:
> #if defined(CONFIG_X86_64) && !defined(CONFIG_UML)
>
> Since this check guards in_ia32_syscall() just checking CONFIG_IA32_EMULATION
> should do too.
>
> (Way outside my limited expertise, but anyway: is does look odd to see a call
> to in_ia32_syscall() in drivers/. All other calls are in arch/x86/. Isn't this
> a bit too x86 specific for an arch independent driver?)
According to Arnd who suggested that fix the problem is basically appears on
x86. He also mentioned the new approach that Christoph Hellwig is working on.
But we decided to go the ifdeffery for better backporting.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-10-07 13:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 9:30 Build regressions/improvements in v5.9-rc8 Geert Uytterhoeven
2020-10-05 9:35 ` Geert Uytterhoeven
2020-10-05 12:58 ` Andy Shevchenko
2020-10-07 11:47 ` Paul Bolle
2020-10-07 11:58 ` Andy Shevchenko
2020-10-07 12:05 ` Paul Bolle
2020-10-07 12:08 ` Richard Weinberger
2020-10-07 12:45 ` Paul Bolle
2020-10-07 13:01 ` Richard Weinberger
2020-10-07 13:02 ` Andy Shevchenko [this message]
2020-10-07 13:48 ` Christoph Hellwig
2020-10-07 14:28 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201007130241.GA4077@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=bgolaszewski@baylibre.com \
--cc=deanbo422@gmail.com \
--cc=geert@linux-m68k.org \
--cc=green.hu@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nickhu@andestech.com \
--cc=pebolle@tiscali.nl \
--cc=richard.weinberger@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox