* [PATCH] xfs: fix Kconfig asking about XFS_SUPPORT_V4 when XFS_FS=n
@ 2020-10-12 21:11 Darrick J. Wong
2020-10-12 21:23 ` Eric Sandeen
0 siblings, 1 reply; 2+ messages in thread
From: Darrick J. Wong @ 2020-10-12 21:11 UTC (permalink / raw)
To: Pavel Machek, xfs; +Cc: kernel list, dchinner, sandeen
From: Darrick J. Wong <darrick.wong@oracle.com>
Pavel Machek complained that the question about supporting deprecated
XFS v4 comes up even when XFS is disabled. This clearly makes no sense,
so fix Kconfig.
Reported-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
fs/xfs/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/xfs/Kconfig b/fs/xfs/Kconfig
index 5422227e9e93..9fac5ea8d0e4 100644
--- a/fs/xfs/Kconfig
+++ b/fs/xfs/Kconfig
@@ -24,6 +24,7 @@ config XFS_FS
config XFS_SUPPORT_V4
bool "Support deprecated V4 (crc=0) format"
+ depends on XFS_FS
default y
help
The V4 filesystem format lacks certain features that are supported
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfs: fix Kconfig asking about XFS_SUPPORT_V4 when XFS_FS=n
2020-10-12 21:11 [PATCH] xfs: fix Kconfig asking about XFS_SUPPORT_V4 when XFS_FS=n Darrick J. Wong
@ 2020-10-12 21:23 ` Eric Sandeen
0 siblings, 0 replies; 2+ messages in thread
From: Eric Sandeen @ 2020-10-12 21:23 UTC (permalink / raw)
To: Darrick J. Wong, Pavel Machek, xfs; +Cc: kernel list, dchinner, sandeen
On 10/12/20 4:11 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Pavel Machek complained that the question about supporting deprecated
> XFS v4 comes up even when XFS is disabled. This clearly makes no sense,
> so fix Kconfig.
>
> Reported-by: Pavel Machek <pavel@ucw.cz>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> ---
> fs/xfs/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/xfs/Kconfig b/fs/xfs/Kconfig
> index 5422227e9e93..9fac5ea8d0e4 100644
> --- a/fs/xfs/Kconfig
> +++ b/fs/xfs/Kconfig
> @@ -24,6 +24,7 @@ config XFS_FS
>
> config XFS_SUPPORT_V4
> bool "Support deprecated V4 (crc=0) format"
> + depends on XFS_FS
> default y
> help
> The V4 filesystem format lacks certain features that are supported
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-12 21:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-12 21:11 [PATCH] xfs: fix Kconfig asking about XFS_SUPPORT_V4 when XFS_FS=n Darrick J. Wong
2020-10-12 21:23 ` Eric Sandeen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox