From: Vinod Koul <vkoul@kernel.org>
To: Jonathan McDowell <noodles@earth.li>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Dan Williams <dan.j.williams@intel.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Thomas Pedersen <twp@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
dmaengine@vger.kernel.org
Subject: Re: [PATCH v4] dmaengine: qcom: Add ADM driver
Date: Mon, 9 Nov 2020 17:11:21 +0530 [thread overview]
Message-ID: <20201109114121.GG3171@vkoul-mobl> (raw)
In-Reply-To: <20200923194056.GY3411@earth.li>
HI Jonathan,
On 23-09-20, 20:40, Jonathan McDowell wrote:
> Add the DMA engine driver for the QCOM Application Data Mover (ADM) DMA
> controller found in the MSM8x60 and IPQ/APQ8064 platforms.
Mostly it looks good, some nitpicks
> The ADM supports both memory to memory transactions and memory
> to/from peripheral device transactions. The controller also provides
> flow control capabilities for transactions to/from peripheral devices.
>
> The initial release of this driver supports slave transfers to/from
> peripherals and also incorporates CRCI (client rate control interface)
> flow control.
Can you also convert the binding from txt to yaml?
> diff --git a/drivers/dma/qcom/Kconfig b/drivers/dma/qcom/Kconfig
> index 3bcb689162c6..0389d60d2604 100644
> --- a/drivers/dma/qcom/Kconfig
> +++ b/drivers/dma/qcom/Kconfig
> @@ -1,4 +1,15 @@
> # SPDX-License-Identifier: GPL-2.0-only
> +config QCOM_ADM
> + tristate "Qualcomm ADM support"
> + depends on (ARCH_QCOM || COMPILE_TEST) && !PHYS_ADDR_T_64BIT
why !PHYS_ADDR_T_64BIT ..?
> + select DMA_ENGINE
> + select DMA_VIRTUAL_CHANNELS
> + help
> + Enable support for the Qualcomm Application Data Mover (ADM) DMA
> + controller, as present on MSM8x60, APQ8064, and IPQ8064 devices.
> + This controller provides DMA capabilities for both general purpose
> + and on-chip peripheral devices.
> +static const struct of_device_id adm_of_match[] = {
> + { .compatible = "qcom,adm", },
I know we have merged the binding, but should we not have a soc specific
compatible?
--
~Vinod
next prev parent reply other threads:[~2020-11-09 11:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 6:43 [PATCH] dmaengine: qcom: Add ADM driver Jonathan McDowell
2020-09-18 11:34 ` Vinod Koul
2020-09-18 18:39 ` Jonathan McDowell
2020-09-19 18:57 ` [PATCH v2] " Jonathan McDowell
2020-09-20 18:12 ` [PATCH v3] " Jonathan McDowell
2020-09-21 8:41 ` Philipp Zabel
2020-09-23 19:40 ` [PATCH v4] " Jonathan McDowell
2020-10-25 18:11 ` Jonathan McDowell
2020-10-28 16:04 ` Vinod Koul
2020-11-09 11:41 ` Vinod Koul [this message]
2020-11-09 19:04 ` Jonathan McDowell
2020-11-10 4:54 ` Vinod Koul
2020-11-14 14:02 ` [PATCH v5] " Jonathan McDowell
2020-11-18 15:50 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201109114121.GG3171@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noodles@earth.li \
--cc=p.zabel@pengutronix.de \
--cc=twp@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox