From: Masami Hiramatsu <mhiramat@kernel.org>
To: Chen Yu <yu.chen.surf@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: bootconfig length parse error in kernel
Date: Wed, 11 Nov 2020 18:37:42 +0900 [thread overview]
Message-ID: <20201111183742.e7c90597216343d9d2ffcb4e@kernel.org> (raw)
In-Reply-To: <CADjb_WSwW4jrNvLp91YHu-qimU1P1itPU_gZ5juQRWER_vGWAA@mail.gmail.com>
Hi Chen,
On Tue, 10 Nov 2020 23:39:53 +0800
Chen Yu <yu.chen.surf@gmail.com> wrote:
> Hi Masami,
> Thanks for writing bootconfig and it is useful for boot up trace event
> debugging.
Thanks for testing!
> However it was found that on 5.10-rc2 the bootconfig does not work and it shows
> "'bootconfig' found on command line, but no bootconfig found"
> And the reason for this is the kernel found the magic number to be incorrect.
> I've added some hack in kernel to dump the first 12 bytes, it shows:
> "OTCONFIG". So printed more content ahead we can find
> "#BOOTCONFIG" ahead. So it looks that there is some alignment during
> initrd load, and get_boot_config_from_initrd() might also deal with it. That is
> to say:
> data = (char *)initrd_end - BOOTCONFIG_MAGIC_LEN;
> might do some alignment?
Hrm, interesting. So initrd_end might be aligned. Could you print out the
actuall address of initrd_end? And could you tell me which platform are
you tested?
Thank you,
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2020-11-11 9:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 15:39 bootconfig length parse error in kernel Chen Yu
2020-11-11 9:37 ` Masami Hiramatsu [this message]
2020-11-12 4:34 ` Chen Yu
2020-11-12 5:50 ` Masami Hiramatsu
2020-11-12 6:49 ` Chen Yu
2020-11-12 15:36 ` Masami Hiramatsu
2020-11-12 17:27 ` [PATCH] bootconfig: Extend the magic check range to the preceding 3 bytes Masami Hiramatsu
2020-11-13 1:27 ` Chen Yu
2020-11-13 2:21 ` Masami Hiramatsu
2020-11-13 3:16 ` Steven Rostedt
2020-11-13 0:49 ` bootconfig length parse error in kernel Chen Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201111183742.e7c90597216343d9d2ffcb4e@kernel.org \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yu.chen.surf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox