public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Xingxing Su <suxingxing@loongson.cn>
Cc: Youling Tang <tangyouling@loongson.cn>,
	linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: Enable GCOV
Date: Fri, 4 Dec 2020 13:08:52 +0100	[thread overview]
Message-ID: <20201204120852.GE10011@alpha.franken.de> (raw)
In-Reply-To: <1606980171-9536-1-git-send-email-suxingxing@loongson.cn>

On Thu, Dec 03, 2020 at 03:22:51PM +0800, Xingxing Su wrote:
> Enable gcov profiling of the entire kernel on mips. Required changes
> include disabling profiling for:
> 
> * arch/kernel/boot/compressed: not linked to main kernel.
> 
> Lightly tested on Loongson 3A3000 an 3A4000, seems to work as expected.
> 
> without "GCOV_PROFILE := n" in compressed Makefile,
> build errors as follows:
> ...
> ld: arch/mips/boot/compressed/string.o:(.data+0x88):
>  undefined reference to `__gcov_merge_add'
> ld: arch/mips/boot/compressed/string.o:
>  in function `_GLOBAL__sub_I_00100_0_memcpy':
> string.c:(.text.startup+0x4): undefined reference to `__gcov_init'
> ld: arch/mips/boot/compressed/string.o:
>  in function `_GLOBAL__sub_D_00100_1_memcpy':
> string.c:(.text.exit+0x0): undefined reference to `__gcov_exit'
> ...
> 
> Signed-off-by: Youling Tang <tangyouling@loongson.cn>
> Signed-off-by: Xingxing Su <suxingxing@loongson.cn>
> ---
>  arch/mips/Kconfig                  | 1 +
>  arch/mips/boot/compressed/Makefile | 1 +
>  2 files changed, 2 insertions(+)

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]

      reply	other threads:[~2020-12-04 12:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-03  7:22 [PATCH] MIPS: Enable GCOV Xingxing Su
2020-12-04 12:08 ` Thomas Bogendoerfer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201204120852.GE10011@alpha.franken.de \
    --to=tsbogend@alpha.franken.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=suxingxing@loongson.cn \
    --cc=tangyouling@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox