* [PATCH] vxlan: avoid double unlikely() notation when using IS_ERR()
@ 2020-12-10 8:55 Antonio Quartulli
2020-12-10 20:45 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Antonio Quartulli @ 2020-12-10 8:55 UTC (permalink / raw)
To: Jakub Kicinski, netdev, linux-kernel; +Cc: Antonio Quartulli
The definition of IS_ERR() already applies the unlikely() notation
when checking the error status of the passed pointer. For this
reason there is no need to have the same notation outside of
IS_ERR() itself.
Clean up code by removing redundant notation.
Signed-off-by: Antonio Quartulli <a@unstable.cc>
---
drivers/net/vxlan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index e1e44d68ac4b..a8ad710629e6 100644
--- a/drivers/net/vxlan.c
+++ b/drivers/net/vxlan.c
@@ -2477,7 +2477,7 @@ static struct dst_entry *vxlan6_get_route(struct vxlan_dev *vxlan,
ndst = ipv6_stub->ipv6_dst_lookup_flow(vxlan->net, sock6->sock->sk,
&fl6, NULL);
- if (unlikely(IS_ERR(ndst))) {
+ if (IS_ERR(ndst)) {
netdev_dbg(dev, "no route to %pI6\n", daddr);
return ERR_PTR(-ENETUNREACH);
}
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] vxlan: avoid double unlikely() notation when using IS_ERR()
2020-12-10 8:55 [PATCH] vxlan: avoid double unlikely() notation when using IS_ERR() Antonio Quartulli
@ 2020-12-10 20:45 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-12-10 20:45 UTC (permalink / raw)
To: a; +Cc: kuba, netdev, linux-kernel
From: Antonio Quartulli <a@unstable.cc>
Date: Thu, 10 Dec 2020 09:55:49 +0100
> The definition of IS_ERR() already applies the unlikely() notation
> when checking the error status of the passed pointer. For this
> reason there is no need to have the same notation outside of
> IS_ERR() itself.
>
> Clean up code by removing redundant notation.
>
> Signed-off-by: Antonio Quartulli <a@unstable.cc>
Applied to net-next, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-12-10 20:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-12-10 8:55 [PATCH] vxlan: avoid double unlikely() notation when using IS_ERR() Antonio Quartulli
2020-12-10 20:45 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox