public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Chris Chiu <chiu@endlessos.org>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	peterz@infradead.org, luto@kernel.org, x86@kernel.org,
	linux-kernel@vger.kernel.org, linux@endlessos.org,
	Dan Nicholson <nicholson@endlessos.org>,
	Jian-Hong Pan <jhp@endlessos.org>
Subject: Re: [PATCH v2] x86/reboot/quirks: Add GIGABYTE BRIX BXBT-2807 reboot quirk
Date: Thu, 10 Dec 2020 19:49:30 +0100	[thread overview]
Message-ID: <20201210184930.GF26529@zn.tnic> (raw)
In-Reply-To: <20201210041946.8961-1-chiu@endlessos.org>

On Thu, Dec 10, 2020 at 12:19:46PM +0800, Chris Chiu wrote:
> From: Dan Nicholson <nicholson@endlessos.org>
> 
> The GIGABYTE BRIX BXBT-2807 always hangs with the normal acpi
> reboot.

Is that what the "hard disk crash" in the comment below, refers to?

> It works without problem after adding the parameter
> reboot=bios.
> 
> Signed-off-by: Dan Nicholson <nicholson@endlessos.org>
> Signed-off-by: Chris Chiu <chiu@endlessos.org>
> Signed-off-by: Jian-Hong Pan <jhp@endlessos.org>

What's Jian's S-o-b tag supposed to mean?

> ---
> 
> v2:
>   - fix typo in the commit message.
> 
>  arch/x86/kernel/reboot.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
> index db115943e8bd..a03344616cd9 100644
> --- a/arch/x86/kernel/reboot.c
> +++ b/arch/x86/kernel/reboot.c
> @@ -467,6 +467,16 @@ static const struct dmi_system_id reboot_dmi_table[] __initconst = {
>  		},
>  	},
>  
> +	/* GIGABYTE */
> +	{	/* Workaround hard disk crash on ACPI reboot */
		^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

  reply	other threads:[~2020-12-10 18:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-10  4:19 [PATCH v2] x86/reboot/quirks: Add GIGABYTE BRIX BXBT-2807 reboot quirk Chris Chiu
2020-12-10 18:49 ` Borislav Petkov [this message]
2020-12-10 23:01   ` Dan Nicholson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201210184930.GF26529@zn.tnic \
    --to=bp@alien8.de \
    --cc=chiu@endlessos.org \
    --cc=hpa@zytor.com \
    --cc=jhp@endlessos.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@endlessos.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=nicholson@endlessos.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox