[PATCH v2] x86/reboot/quirks: Add GIGABYTE BRIX BXBT-2807 reboot quirk

[PATCH v2] x86/reboot/quirks: Add GIGABYTE BRIX BXBT-2807 reboot quirk

[Chris Chiu]

From: Dan Nicholson <nicholson@endlessos.org>

The GIGABYTE BRIX BXBT-2807 always hangs with the normal acpi
reboot. It works without problem after adding the parameter
reboot=bios.

Signed-off-by: Dan Nicholson <nicholson@endlessos.org>
Signed-off-by: Chris Chiu <chiu@endlessos.org>
Signed-off-by: Jian-Hong Pan <jhp@endlessos.org>
---

v2:
  - fix typo in the commit message.

 arch/x86/kernel/reboot.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
index db115943e8bd..a03344616cd9 100644
--- a/arch/x86/kernel/reboot.c
+++ b/arch/x86/kernel/reboot.c
@@ -467,6 +467,16 @@ static const struct dmi_system_id reboot_dmi_table[] __initconst = {
 		},
 	},
 
+	/* GIGABYTE */
+	{	/* Workaround hard disk crash on ACPI reboot */
+		.callback = set_bios_reboot,
+		.ident = "GIGABYTE BRIX BXBT-2807",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "GIGABYTE"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "GB-BXBT-2807"),
+		},
+	},
+
 	/* Hewlett-Packard */
 	{	/* Handle problems with rebooting on HP laptops */
 		.callback = set_bios_reboot,
-- 
2.20.1

Re: [PATCH v2] x86/reboot/quirks: Add GIGABYTE BRIX BXBT-2807 reboot quirk

[Borislav Petkov]

On Thu, Dec 10, 2020 at 12:19:46PM +0800, Chris Chiu wrote:
> From: Dan Nicholson <nicholson@endlessos.org>
> 
> The GIGABYTE BRIX BXBT-2807 always hangs with the normal acpi
> reboot.

Is that what the "hard disk crash" in the comment below, refers to?

> It works without problem after adding the parameter
> reboot=bios.
> 
> Signed-off-by: Dan Nicholson <nicholson@endlessos.org>
> Signed-off-by: Chris Chiu <chiu@endlessos.org>
> Signed-off-by: Jian-Hong Pan <jhp@endlessos.org>

What's Jian's S-o-b tag supposed to mean?

> ---
> 
> v2:
>   - fix typo in the commit message.
> 
>  arch/x86/kernel/reboot.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
> index db115943e8bd..a03344616cd9 100644
> --- a/arch/x86/kernel/reboot.c
> +++ b/arch/x86/kernel/reboot.c
> @@ -467,6 +467,16 @@ static const struct dmi_system_id reboot_dmi_table[] __initconst = {
>  		},
>  	},
>  
> +	/* GIGABYTE */
> +	{	/* Workaround hard disk crash on ACPI reboot */
		^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

Re: [PATCH v2] x86/reboot/quirks: Add GIGABYTE BRIX BXBT-2807 reboot quirk

[Dan Nicholson]

On Thu, Dec 10, 2020 at 11:49 AM Borislav Petkov <bp@alien8.de> wrote:
>
> On Thu, Dec 10, 2020 at 12:19:46PM +0800, Chris Chiu wrote:
> > From: Dan Nicholson <nicholson@endlessos.org>
> >
> > The GIGABYTE BRIX BXBT-2807 always hangs with the normal acpi
> > reboot.
>
> Is that what the "hard disk crash" in the comment below, refers to?

Hmm, when I wrote this patch several years back there wasn't any hang
when rebooting. According to our internal bug tracker, you could hear
the disk head crashing on reboot. The workaround was to do a BIOS
reboot rather than an ACPI reboot. My original commit message was:

    x86/reboot: Use bios reboot for GIGABYTE BRIX BXBT-2807

    Using ACPI, the hard disk crashes on reboot. This seems to be avoided
    when using the BIOS to reboot.

I don't know if this became a hang with more recent kernels as
described in this commit message. Chris?

--
Dan