[PATCH] mfd: sgi-ioc3: Turn Kconfig option into a bool

[PATCH] mfd: sgi-ioc3: Turn Kconfig option into a bool

[Thomas Bogendoerfer]

Module builds of ioc3 fail with following errors:

ERROR: "spurious_interrupt" [drivers/mfd/ioc3.ko] undefined!
ERROR: "pci_find_host_bridge" [drivers/mfd/ioc3.ko] undefined!

Exporting pci_find_host_bridge got rejected by maintainer, so easiest
fix is to disable module building, which even makes sense since both
SGI Origin and Octane always contain at least one IOC3 chip.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
---
 drivers/mfd/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 8b99a13669bf..2732d2899234 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -2141,7 +2141,7 @@ config RAVE_SP_CORE
 	  device found on several devices in RAVE line of hardware.
 
 config SGI_MFD_IOC3
-	tristate "SGI IOC3 core driver"
+	bool "SGI IOC3 core driver"
 	depends on PCI && MIPS && 64BIT
 	select MFD_CORE
 	help
-- 
2.16.4

Re: [PATCH] mfd: sgi-ioc3: Turn Kconfig option into a bool

[Lee Jones]

On Mon, 07 Dec 2020, Thomas Bogendoerfer wrote:

> Module builds of ioc3 fail with following errors:
> 
> ERROR: "spurious_interrupt" [drivers/mfd/ioc3.ko] undefined!
> ERROR: "pci_find_host_bridge" [drivers/mfd/ioc3.ko] undefined!
> 
> Exporting pci_find_host_bridge got rejected by maintainer, so easiest
> fix is to disable module building, which even makes sense since both
> SGI Origin and Octane always contain at least one IOC3 chip.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> ---
>  drivers/mfd/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog