* [PATCH] dm zoned: select CONFIG_CRC32
@ 2021-01-03 21:40 Arnd Bergmann
2021-01-03 23:13 ` Damien Le Moal
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2021-01-03 21:40 UTC (permalink / raw)
To: Alasdair Kergon, Mike Snitzer, dm-devel, Song Liu,
Bart Van Assche, Hannes Reinecke, Damien Le Moal
Cc: Arnd Bergmann, linux-raid, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Without crc32 support, this driver fails to link:
arm-linux-gnueabi-ld: drivers/md/dm-zoned-metadata.o: in function `dmz_write_sb':
dm-zoned-metadata.c:(.text+0xe98): undefined reference to `crc32_le'
arm-linux-gnueabi-ld: drivers/md/dm-zoned-metadata.o: in function `dmz_check_sb':
dm-zoned-metadata.c:(.text+0x7978): undefined reference to `crc32_le'
Fixes: 3b1a94c88b79 ("dm zoned: drive-managed zoned block device target")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/md/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig
index b7e2d9666614..a67b9ed3ca89 100644
--- a/drivers/md/Kconfig
+++ b/drivers/md/Kconfig
@@ -622,6 +622,7 @@ config DM_ZONED
tristate "Drive-managed zoned block device target support"
depends on BLK_DEV_DM
depends on BLK_DEV_ZONED
+ select CRC32
help
This device-mapper target takes a host-managed or host-aware zoned
block device and exposes most of its capacity as a regular block
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] dm zoned: select CONFIG_CRC32
2021-01-03 21:40 [PATCH] dm zoned: select CONFIG_CRC32 Arnd Bergmann
@ 2021-01-03 23:13 ` Damien Le Moal
0 siblings, 0 replies; 2+ messages in thread
From: Damien Le Moal @ 2021-01-03 23:13 UTC (permalink / raw)
To: Arnd Bergmann, Alasdair Kergon, Mike Snitzer, dm-devel@redhat.com,
Song Liu, Bart Van Assche, Hannes Reinecke
Cc: Arnd Bergmann, linux-raid@vger.kernel.org,
linux-kernel@vger.kernel.org
On 2021/01/04 6:41, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Without crc32 support, this driver fails to link:
>
> arm-linux-gnueabi-ld: drivers/md/dm-zoned-metadata.o: in function `dmz_write_sb':
> dm-zoned-metadata.c:(.text+0xe98): undefined reference to `crc32_le'
> arm-linux-gnueabi-ld: drivers/md/dm-zoned-metadata.o: in function `dmz_check_sb':
> dm-zoned-metadata.c:(.text+0x7978): undefined reference to `crc32_le'
>
> Fixes: 3b1a94c88b79 ("dm zoned: drive-managed zoned block device target")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/md/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig
> index b7e2d9666614..a67b9ed3ca89 100644
> --- a/drivers/md/Kconfig
> +++ b/drivers/md/Kconfig
> @@ -622,6 +622,7 @@ config DM_ZONED
> tristate "Drive-managed zoned block device target support"
> depends on BLK_DEV_DM
> depends on BLK_DEV_ZONED
> + select CRC32
> help
> This device-mapper target takes a host-managed or host-aware zoned
> block device and exposes most of its capacity as a regular block
>
Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-03 23:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-03 21:40 [PATCH] dm zoned: select CONFIG_CRC32 Arnd Bergmann
2021-01-03 23:13 ` Damien Le Moal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox