From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Shuah Khan <shuah@kernel.org>,
patches@opensource.cirrus.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: Re: [PATCH v3 1/4] lib: vsprintf: scanf: Negative number must have field width > 1
Date: Mon, 11 Jan 2021 13:14:09 +0200 [thread overview]
Message-ID: <20210111111409.GW4077@smile.fi.intel.com> (raw)
In-Reply-To: <395b37b8-d9b2-1825-8e57-9e1b74aa7502@opensource.cirrus.com>
On Mon, Jan 11, 2021 at 10:43:17AM +0000, Richard Fitzgerald wrote:
> On 11/01/2021 10:39, Richard Fitzgerald wrote:
> > On 11/01/2021 10:36, Andy Shevchenko wrote:
> > > On Mon, Jan 11, 2021 at 12:28 PM Petr Mladek <pmladek@suse.com> wrote:
> > > >
> > > > Sigh, I have just realized that Andy and Rasmus, the other
> > > > vsprintf maintainers and reviewers, were not in CC.
> > > > I am sorry for not noticing this earlier.
> > > >
> > > > The patchset is ready for 5.12 from my POV.
> > >
> > > Thanks, Petr!
> > >
> > > I have one question, do we have a test case for that? If not, I prefer
> > > defer until a test case will be provided.
> > >
> >
> > See patch 3, numbers_prefix_overflow()
>
> Sorry, I missed you off the original mailing so you won't have
> seen the other patches.
> Patch 3 with the test cases is here:
> https://lore.kernel.org/lkml/X%2FwnoJLEt0zQskDU@alley/T/#mf2ffba20126e438bea7af171bc78fdbebdb40027
Good, you did it!
Couple of remarks:
- free resources in the same function where you allocated them
- use post increment where it doesn't matter (like total_test)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-01-11 11:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 18:00 [PATCH v3 1/4] lib: vsprintf: scanf: Negative number must have field width > 1 Richard Fitzgerald
2020-12-17 18:00 ` [PATCH v3 2/4] lib: vsprintf: Fix handling of number field widths in vsscanf Richard Fitzgerald
2020-12-21 15:19 ` Petr Mladek
2020-12-17 18:00 ` [PATCH v3 3/4] lib: test_scanf: Add tests for sscanf number conversion Richard Fitzgerald
2020-12-21 15:21 ` Petr Mladek
2020-12-17 18:00 ` [PATCH v3 4/4] selftests: lib: Add wrapper script for test_scanf Richard Fitzgerald
2020-12-21 15:16 ` [PATCH v3 1/4] lib: vsprintf: scanf: Negative number must have field width > 1 Petr Mladek
2021-01-11 10:25 ` Petr Mladek
2021-01-11 10:36 ` Andy Shevchenko
2021-01-11 10:39 ` Richard Fitzgerald
2021-01-11 10:43 ` Richard Fitzgerald
2021-01-11 11:14 ` Andy Shevchenko [this message]
2021-01-11 10:37 ` Richard Fitzgerald
2021-01-11 11:15 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210111111409.GW4077@smile.fi.intel.com \
--to=andy.shevchenko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=patches@opensource.cirrus.com \
--cc=pmladek@suse.com \
--cc=rf@opensource.cirrus.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox