From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"rppt@kernel.org" <rppt@kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"jason@lakedaemon.net" <jason@lakedaemon.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Grégory Clement" <gregory.clement@bootlin.com>
Subject: Re: [PATCH] bus: mvebu-mbus: make iounmap() symmetric with ioremap()
Date: Tue, 26 Jan 2021 09:05:25 +0100 [thread overview]
Message-ID: <20210126090525.4d085080@windsurf.home> (raw)
In-Reply-To: <7c0fd747-3ea1-2aa1-0c05-12ae4477a860@alliedtelesis.co.nz>
On Tue, 26 Jan 2021 01:48:23 +0000
Chris Packham <Chris.Packham@alliedtelesis.co.nz> wrote:
> Hi All,
>
> On 12/11/20 9:02 pm, Thomas Petazzoni wrote:
> > On Thu, 12 Nov 2020 16:21:49 +1300
> > Chris Packham <chris.packham@alliedtelesis.co.nz> wrote:
> >
> >> make coccicheck complains:
> >>
> >> ./drivers/bus/mvebu-mbus.c:1113:2-8: ERROR: missing iounmap; ioremap on line 1106 and execution via conditional on line 1111
> >>
> >> It took some staring but I don't think there is a problem because the
> >> file global `mbus_state` is passed mvebu_mbus_common_init() as the
> >> `mbus` parameter so `mbus_state.mbuswins_base` and `mbus->mbuswins_base`
> >> are the same thing. But this is confusing for anyone reading the code
> >> and one less complaint from coccicheck would be nice so lets fix it.
> >>
> >> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> > Acked-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
>
> Just going through some old branches. This doesn't seem to have been
> picked up. Have I missed a maintainer?
+Gregory Clement in Cc. Greg, the original patch from Chris is touching
drivers/bus/mvebu-mbus.c, so I think you should be taking that patch.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2021-01-26 17:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 3:21 [PATCH] bus: mvebu-mbus: make iounmap() symmetric with ioremap() Chris Packham
2020-11-12 8:02 ` Thomas Petazzoni
2021-01-26 1:48 ` Chris Packham
2021-01-26 8:05 ` Thomas Petazzoni [this message]
[not found] ` <87r1m3speo.fsf@BL-laptop>
2021-01-29 16:28 ` Thomas Petazzoni
2021-01-29 16:59 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210126090525.4d085080@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=Chris.Packham@alliedtelesis.co.nz \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=gregory.clement@bootlin.com \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox