From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: akpm@linux-foundation.org, rppt@kernel.org,
thomas.petazzoni@free-electrons.com, arnd@arndb.de,
jason@lakedaemon.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bus: mvebu-mbus: make iounmap() symmetric with ioremap()
Date: Thu, 12 Nov 2020 09:02:02 +0100 [thread overview]
Message-ID: <20201112090202.638c0c13@windsurf> (raw)
In-Reply-To: <20201112032149.21906-1-chris.packham@alliedtelesis.co.nz>
On Thu, 12 Nov 2020 16:21:49 +1300
Chris Packham <chris.packham@alliedtelesis.co.nz> wrote:
> make coccicheck complains:
>
> ./drivers/bus/mvebu-mbus.c:1113:2-8: ERROR: missing iounmap; ioremap on line 1106 and execution via conditional on line 1111
>
> It took some staring but I don't think there is a problem because the
> file global `mbus_state` is passed mvebu_mbus_common_init() as the
> `mbus` parameter so `mbus_state.mbuswins_base` and `mbus->mbuswins_base`
> are the same thing. But this is confusing for anyone reading the code
> and one less complaint from coccicheck would be nice so lets fix it.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Acked-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-11-12 8:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 3:21 [PATCH] bus: mvebu-mbus: make iounmap() symmetric with ioremap() Chris Packham
2020-11-12 8:02 ` Thomas Petazzoni [this message]
2021-01-26 1:48 ` Chris Packham
2021-01-26 8:05 ` Thomas Petazzoni
[not found] ` <87r1m3speo.fsf@BL-laptop>
2021-01-29 16:28 ` Thomas Petazzoni
2021-01-29 16:59 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201112090202.638c0c13@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rppt@kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox