* [PATCH -next v2] sched/topology: Mark some symbols with static keyword
@ 2020-11-25 2:30 Zou Wei
2021-02-02 12:32 ` Ionela Voinescu
0 siblings, 1 reply; 2+ messages in thread
From: Zou Wei @ 2020-11-25 2:30 UTC (permalink / raw)
To: mingo, peterz, juri.lelli, vincent.guittot, dietmar.eggemann,
rostedt, bsegall, mgorman, bristot, qperret, ionela.voinescu,
rafael.j.wysocki
Cc: linux-kernel, Zou Wei
Fix the following sparse warnings:
kernel/sched/topology.c:211:1: warning: symbol 'sched_energy_mutex' was not declared. Should it be static?
kernel/sched/topology.c:212:6: warning: symbol 'sched_energy_update' was not declared. Should it be static?
Fixes: 31f6a8c0a471 ("sched/topology,schedutil: Wrap sched domains rebuild")
Signed-off-by: Zou Wei <zou_wei@huawei.com>
---
kernel/sched/topology.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
index 5d3675c..2676687 100644
--- a/kernel/sched/topology.c
+++ b/kernel/sched/topology.c
@@ -208,8 +208,8 @@ sd_parent_degenerate(struct sched_domain *sd, struct sched_domain *parent)
#if defined(CONFIG_ENERGY_MODEL) && defined(CONFIG_CPU_FREQ_GOV_SCHEDUTIL)
DEFINE_STATIC_KEY_FALSE(sched_energy_present);
unsigned int sysctl_sched_energy_aware = 1;
-DEFINE_MUTEX(sched_energy_mutex);
-bool sched_energy_update;
+static DEFINE_MUTEX(sched_energy_mutex);
+static bool sched_energy_update;
void rebuild_sched_domains_energy(void)
{
--
2.6.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next v2] sched/topology: Mark some symbols with static keyword
2020-11-25 2:30 [PATCH -next v2] sched/topology: Mark some symbols with static keyword Zou Wei
@ 2021-02-02 12:32 ` Ionela Voinescu
0 siblings, 0 replies; 2+ messages in thread
From: Ionela Voinescu @ 2021-02-02 12:32 UTC (permalink / raw)
To: Zou Wei
Cc: xuewen.yan, mingo, peterz, juri.lelli, vincent.guittot,
dietmar.eggemann, rostedt, bsegall, mgorman, bristot, qperret,
rafael.j.wysocki, linux-kernel
Hi,
+Xuewen Yan, who submitted a similar patch recently.
On Wednesday 25 Nov 2020 at 10:30:47 (+0800), Zou Wei wrote:
> Fix the following sparse warnings:
>
> kernel/sched/topology.c:211:1: warning: symbol 'sched_energy_mutex' was not declared. Should it be static?
> kernel/sched/topology.c:212:6: warning: symbol 'sched_energy_update' was not declared. Should it be static?
>
> Fixes: 31f6a8c0a471 ("sched/topology,schedutil: Wrap sched domains rebuild")
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
> kernel/sched/topology.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
> index 5d3675c..2676687 100644
> --- a/kernel/sched/topology.c
> +++ b/kernel/sched/topology.c
> @@ -208,8 +208,8 @@ sd_parent_degenerate(struct sched_domain *sd, struct sched_domain *parent)
> #if defined(CONFIG_ENERGY_MODEL) && defined(CONFIG_CPU_FREQ_GOV_SCHEDUTIL)
> DEFINE_STATIC_KEY_FALSE(sched_energy_present);
> unsigned int sysctl_sched_energy_aware = 1;
> -DEFINE_MUTEX(sched_energy_mutex);
> -bool sched_energy_update;
> +static DEFINE_MUTEX(sched_energy_mutex);
> +static bool sched_energy_update;
>
Reviewed-by: Ionela Voinescu <ionela.voinescu@arm.com>
Apologies for introducing these warnings with my previous patch.
Kind regards,
Ionela.
> void rebuild_sched_domains_energy(void)
> {
> --
> 2.6.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-02 12:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-25 2:30 [PATCH -next v2] sched/topology: Mark some symbols with static keyword Zou Wei
2021-02-02 12:32 ` Ionela Voinescu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox