From: Lee Jones <lee.jones@linaro.org>
To: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Cc: Robert Jones <rjones@gateworks.com>,
Tim Harvey <tharvey@gateworks.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] mfd: gateworks-gsc: Constify static struct attribute_group
Date: Mon, 1 Mar 2021 09:56:45 +0000 [thread overview]
Message-ID: <20210301095645.GG641347@dell> (raw)
In-Reply-To: <20210131133644.8834-2-rikard.falkeborn@gmail.com>
On Sun, 31 Jan 2021, Rikard Falkeborn wrote:
> The only usage of attr_group is to pass its address to
> sysfs_create_group() and sysfs_remove_group(), both which takes pointers
> to const attribute_group structs. Make it const to allow the compiler to
> put it in read-only memory.
>
> Done with the help of coccinelle.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
> ---
> drivers/mfd/gateworks-gsc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
These patches do not seem to be on LKML.
Do you know if they were rejected for some reason?
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next parent reply other threads:[~2021-03-01 10:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210131133644.8834-1-rikard.falkeborn@gmail.com>
[not found] ` <20210131133644.8834-2-rikard.falkeborn@gmail.com>
2021-03-01 9:56 ` Lee Jones [this message]
2021-03-01 21:11 ` [PATCH 1/3] mfd: gateworks-gsc: Constify static struct attribute_group Rikard Falkeborn
2021-03-02 9:34 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210301095645.GG641347@dell \
--to=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rikard.falkeborn@gmail.com \
--cc=rjones@gateworks.com \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox