Re: [PATCH 1/3] mfd: gateworks-gsc: Constify static struct attribute_group

Re: [PATCH 1/3] mfd: gateworks-gsc: Constify static struct attribute_group

[Lee Jones]

On Sun, 31 Jan 2021, Rikard Falkeborn wrote:

> The only usage of attr_group is to pass its address to
> sysfs_create_group() and sysfs_remove_group(), both which takes pointers
> to const attribute_group structs. Make it const to allow the compiler to
> put it in read-only memory.
> 
> Done with the help of coccinelle.
> 
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
> ---
>  drivers/mfd/gateworks-gsc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

These patches do not seem to be on LKML.

Do you know if they were rejected for some reason?

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH 1/3] mfd: gateworks-gsc: Constify static struct attribute_group

[Rikard Falkeborn]

On Mon, Mar 01, 2021 at 09:56:45AM +0000, Lee Jones wrote:
> On Sun, 31 Jan 2021, Rikard Falkeborn wrote:
> 
> > The only usage of attr_group is to pass its address to
> > sysfs_create_group() and sysfs_remove_group(), both which takes pointers
> > to const attribute_group structs. Make it const to allow the compiler to
> > put it in read-only memory.
> > 
> > Done with the help of coccinelle.
> > 
> > Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
> > ---
> >  drivers/mfd/gateworks-gsc.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> These patches do not seem to be on LKML.
> 
> Do you know if they were rejected for some reason?
> 

I did not recieve any bounce or rejection emails. I have a vague memory
that I saw someone mentioning in another mail that there was some
problems with LKML and that patches were lost, but I can't find it now,
and I'm not sure if it was around the same time as these patches were
sent.

Should I resend the series?

/Rikard

Re: [PATCH 1/3] mfd: gateworks-gsc: Constify static struct attribute_group

[Lee Jones]

On Mon, 01 Mar 2021, Rikard Falkeborn wrote:

> On Mon, Mar 01, 2021 at 09:56:45AM +0000, Lee Jones wrote:
> > On Sun, 31 Jan 2021, Rikard Falkeborn wrote:
> > 
> > > The only usage of attr_group is to pass its address to
> > > sysfs_create_group() and sysfs_remove_group(), both which takes pointers
> > > to const attribute_group structs. Make it const to allow the compiler to
> > > put it in read-only memory.
> > > 
> > > Done with the help of coccinelle.
> > > 
> > > Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
> > > ---
> > >  drivers/mfd/gateworks-gsc.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > These patches do not seem to be on LKML.
> > 
> > Do you know if they were rejected for some reason?
> > 
> 
> I did not recieve any bounce or rejection emails. I have a vague memory
> that I saw someone mentioning in another mail that there was some
> problems with LKML and that patches were lost, but I can't find it now,
> and I'm not sure if it was around the same time as these patches were
> sent.
> 
> Should I resend the series?

Please submit a [RESEND].

If it fails again, I'll apply the patches manually.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog