* [PATCH] drivers: scsi: qla4xxx: Fix a spello in the file qla4xxx/ql4_os.c
@ 2021-03-01 13:17 Bhaskar Chowdhury
2021-03-01 16:56 ` Randy Dunlap
2021-03-16 3:14 ` Martin K. Petersen
0 siblings, 2 replies; 4+ messages in thread
From: Bhaskar Chowdhury @ 2021-03-01 13:17 UTC (permalink / raw)
To: GR-QLogic-Storage-Upstream, jejb, martin.petersen, linux-scsi,
linux-kernel
Cc: rdunlap, Bhaskar Chowdhury
s/circuting/circuiting/
Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
---
drivers/scsi/qla4xxx/ql4_os.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
index a4b014e1cd8c..716a5827588c 100644
--- a/drivers/scsi/qla4xxx/ql4_os.c
+++ b/drivers/scsi/qla4xxx/ql4_os.c
@@ -6961,7 +6961,7 @@ static int qla4xxx_sess_conn_setup(struct scsi_qla_host *ha,
if (is_reset == RESET_ADAPTER) {
iscsi_block_session(cls_sess);
/* Use the relogin path to discover new devices
- * by short-circuting the logic of setting
+ * by short-circuiting the logic of setting
* timer to relogin - instead set the flags
* to initiate login right away.
*/
--
2.26.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] drivers: scsi: qla4xxx: Fix a spello in the file qla4xxx/ql4_os.c
2021-03-01 13:17 [PATCH] drivers: scsi: qla4xxx: Fix a spello in the file qla4xxx/ql4_os.c Bhaskar Chowdhury
@ 2021-03-01 16:56 ` Randy Dunlap
2021-03-01 20:18 ` Bhaskar Chowdhury
2021-03-16 3:14 ` Martin K. Petersen
1 sibling, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2021-03-01 16:56 UTC (permalink / raw)
To: Bhaskar Chowdhury, GR-QLogic-Storage-Upstream, jejb,
martin.petersen, linux-scsi, linux-kernel
On 3/1/21 5:17 AM, Bhaskar Chowdhury wrote:
>
> s/circuting/circuiting/
>
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
However:
In lots of your patches, the subject begins with drivers:
and we don't need that. See the SCSI qla4xxx driver patches, e.g.:
$ git log --oneline drivers/scsi/qla4xxx/
5b0ec4cf0494 scsi: qla4xxx: Use iscsi_is_session_online()
35f1cad1f928 scsi: qla4xxx: Use standard SAM status definitions
3a5b9fa2cc5f scsi: qla4xxx: Remove redundant assignment to variable rval
014aced18aff scsi: qla4xxx: Remove in_interrupt() from qla4_82xx_rom_lock()
3627668c2e2c scsi: qla4xxx: Remove in_interrupt() from qla4_82xx_idc_lock()
a93c38353198 scsi: qla4xxx: Remove in_interrupt()
cf4d4d8ebdb8 scsi: qla4xxx: Remove redundant assignment to variable rval
5ccdd101351d scsi: qla4xxx: Fix inconsistent format argument type
121432e87093 scsi: qla4xxx: Delete unneeded variable 'status' in qla4xxx_process_ddb_changed
e3976af5a475 scsi/qla4xxx: Convert to SPDX license identifiers
574918e69720 scsi: qla4xxx: Fix an error handling path in 'qla4xxx_get_host_stats()'
d10d1df6301d scsi: qla4xxx: Rename function parameter descriptions
6e3f4f68821b scsi: qla4xxx: Remove set but unused variable 'status'
653557df36e0 scsi: qla4xxx: Supply description for 'code'
f67e81641db7 scsi: qla4xxx: Remove three set but unused variables
c0ad04b4b6d7 scsi: qla4xxx: Document qla4xxx_process_ddb()'s 'conn_err'
fc5fba6e2ae2 scsi: qla4xxx: Repair function documentation headers
cdeeb36d8f24 scsi: qla4xxx: Fix some kerneldoc parameter documentation issues
67b8b93a559f scsi: qla4xxx: Fix incorrectly named function parameter
0d5fea42989e scsi: qla4xxx: Fix-up incorrectly documented parameter
> ---
> drivers/scsi/qla4xxx/ql4_os.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
> index a4b014e1cd8c..716a5827588c 100644
> --- a/drivers/scsi/qla4xxx/ql4_os.c
> +++ b/drivers/scsi/qla4xxx/ql4_os.c
> @@ -6961,7 +6961,7 @@ static int qla4xxx_sess_conn_setup(struct scsi_qla_host *ha,
> if (is_reset == RESET_ADAPTER) {
> iscsi_block_session(cls_sess);
> /* Use the relogin path to discover new devices
> - * by short-circuting the logic of setting
> + * by short-circuiting the logic of setting
> * timer to relogin - instead set the flags
> * to initiate login right away.
> */
> --
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drivers: scsi: qla4xxx: Fix a spello in the file qla4xxx/ql4_os.c
2021-03-01 16:56 ` Randy Dunlap
@ 2021-03-01 20:18 ` Bhaskar Chowdhury
0 siblings, 0 replies; 4+ messages in thread
From: Bhaskar Chowdhury @ 2021-03-01 20:18 UTC (permalink / raw)
To: Randy Dunlap
Cc: GR-QLogic-Storage-Upstream, jejb, martin.petersen, linux-scsi,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 2634 bytes --]
On 08:56 Mon 01 Mar 2021, Randy Dunlap wrote:
>On 3/1/21 5:17 AM, Bhaskar Chowdhury wrote:
>>
>> s/circuting/circuiting/
>>
>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>
>Acked-by: Randy Dunlap <rdunlap@infradead.org>
>
>However:
>In lots of your patches, the subject begins with drivers:
>and we don't need that. See the SCSI qla4xxx driver patches, e.g.:
>
Thanks, Randy....took note...about this ...will practice...
>$ git log --oneline drivers/scsi/qla4xxx/
>5b0ec4cf0494 scsi: qla4xxx: Use iscsi_is_session_online()
>35f1cad1f928 scsi: qla4xxx: Use standard SAM status definitions
>3a5b9fa2cc5f scsi: qla4xxx: Remove redundant assignment to variable rval
>014aced18aff scsi: qla4xxx: Remove in_interrupt() from qla4_82xx_rom_lock()
>3627668c2e2c scsi: qla4xxx: Remove in_interrupt() from qla4_82xx_idc_lock()
>a93c38353198 scsi: qla4xxx: Remove in_interrupt()
>cf4d4d8ebdb8 scsi: qla4xxx: Remove redundant assignment to variable rval
>5ccdd101351d scsi: qla4xxx: Fix inconsistent format argument type
>121432e87093 scsi: qla4xxx: Delete unneeded variable 'status' in qla4xxx_process_ddb_changed
>e3976af5a475 scsi/qla4xxx: Convert to SPDX license identifiers
>574918e69720 scsi: qla4xxx: Fix an error handling path in 'qla4xxx_get_host_stats()'
>d10d1df6301d scsi: qla4xxx: Rename function parameter descriptions
>6e3f4f68821b scsi: qla4xxx: Remove set but unused variable 'status'
>653557df36e0 scsi: qla4xxx: Supply description for 'code'
>f67e81641db7 scsi: qla4xxx: Remove three set but unused variables
>c0ad04b4b6d7 scsi: qla4xxx: Document qla4xxx_process_ddb()'s 'conn_err'
>fc5fba6e2ae2 scsi: qla4xxx: Repair function documentation headers
>cdeeb36d8f24 scsi: qla4xxx: Fix some kerneldoc parameter documentation issues
>67b8b93a559f scsi: qla4xxx: Fix incorrectly named function parameter
>0d5fea42989e scsi: qla4xxx: Fix-up incorrectly documented parameter
>
>> ---
>> drivers/scsi/qla4xxx/ql4_os.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
>> index a4b014e1cd8c..716a5827588c 100644
>> --- a/drivers/scsi/qla4xxx/ql4_os.c
>> +++ b/drivers/scsi/qla4xxx/ql4_os.c
>> @@ -6961,7 +6961,7 @@ static int qla4xxx_sess_conn_setup(struct scsi_qla_host *ha,
>> if (is_reset == RESET_ADAPTER) {
>> iscsi_block_session(cls_sess);
>> /* Use the relogin path to discover new devices
>> - * by short-circuting the logic of setting
>> + * by short-circuiting the logic of setting
>> * timer to relogin - instead set the flags
>> * to initiate login right away.
>> */
>> --
>
>
>--
>~Randy
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers: scsi: qla4xxx: Fix a spello in the file qla4xxx/ql4_os.c
2021-03-01 13:17 [PATCH] drivers: scsi: qla4xxx: Fix a spello in the file qla4xxx/ql4_os.c Bhaskar Chowdhury
2021-03-01 16:56 ` Randy Dunlap
@ 2021-03-16 3:14 ` Martin K. Petersen
1 sibling, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2021-03-16 3:14 UTC (permalink / raw)
To: jejb, Bhaskar Chowdhury, GR-QLogic-Storage-Upstream, linux-scsi,
linux-kernel
Cc: Martin K . Petersen, rdunlap
On Mon, 1 Mar 2021 18:47:36 +0530, Bhaskar Chowdhury wrote:
> s/circuting/circuiting/
Applied to 5.13/scsi-queue, thanks!
[1/1] drivers: scsi: qla4xxx: Fix a spello in the file qla4xxx/ql4_os.c
https://git.kernel.org/mkp/scsi/c/014ace23a5ec
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-16 3:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-01 13:17 [PATCH] drivers: scsi: qla4xxx: Fix a spello in the file qla4xxx/ql4_os.c Bhaskar Chowdhury
2021-03-01 16:56 ` Randy Dunlap
2021-03-01 20:18 ` Bhaskar Chowdhury
2021-03-16 3:14 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox