From: Wilken Gottwalt <wilken.gottwalt@posteo.net>
To: Maxime Ripard <mripard@kernel.org>
Cc: linux-kernel@vger.kernel.org, Ohad Ben-Cohen <ohad@wizery.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Baolin Wang <baolin.wang7@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@siol.net>
Subject: Re: [PATCH v6 1/2] dt-bindings: hwlock: add sun6i_hwspinlock
Date: Mon, 1 Mar 2021 15:06:35 +0100 [thread overview]
Message-ID: <20210301150635.480934a8@monster.powergraphx.local> (raw)
In-Reply-To: <20210301131244.otn7vzhgstufjts2@hendrix>
On Mon, 1 Mar 2021 14:12:44 +0100
Maxime Ripard <mripard@kernel.org> wrote:
> On Sat, Feb 27, 2021 at 02:03:28PM +0100, Wilken Gottwalt wrote:
> > Adds documentation on how to use the sun6i_hwspinlock driver for sun6i
> > compatible series SoCs.
> >
> > Signed-off-by: Wilken Gottwalt <wilken.gottwalt@posteo.net>
> > ---
> > Changes in v6:
> > - fixed formating and name issues in dt documentation
> >
> > Changes in v5:
> > - changed binding to earliest known supported SoC sun6i-a31
> > - dropped unnecessary entries
> >
> > Changes in v4:
> > - changed binding to sun8i-a33-hwpinlock
> > - added changes suggested by Maxime Ripard
> >
> > Changes in v3:
> > - changed symbols from sunxi to sun8i
> >
> > Changes in v2:
> > - fixed memory ranges
> > ---
> > .../hwlock/allwinner,sun6i-hwspinlock.yaml | 45 +++++++++++++++++++
>
> The name of the file doesn't match the compatible, once fixed:
> Acked-by: Maxime Ripard <mripard@kernel.org>
This is something that still confuses me. What if you have more than one
compatible string? This won't be solvable. See the qcom binding for example,
there are two strings and none matches. In the omap bindings are also two
strings and only one matches. In all cases, including mine, the bindings
check script is fine with that.
So, you basically want it to be called "allwinner,sun6i-a31-hwspinlock.yaml"?
Sorry if I come up with this, but I don't want to just do it, I want to
understand it.
> Maxime
next prev parent reply other threads:[~2021-03-01 14:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-27 13:02 [PATCH v6 0/2] hwspinlock: add sun6i hardware spinlock support Wilken Gottwalt
2021-02-27 13:03 ` [PATCH v6 1/2] dt-bindings: hwlock: add sun6i_hwspinlock Wilken Gottwalt
2021-03-01 13:12 ` Maxime Ripard
2021-03-01 14:06 ` Wilken Gottwalt [this message]
2021-03-02 17:22 ` Maxime Ripard
2021-03-06 11:07 ` Wilken Gottwalt
2021-02-27 13:03 ` [PATCH v6 2/2] hwspinlock: add sun6i hardware spinlock support Wilken Gottwalt
2021-03-01 13:13 ` Maxime Ripard
2021-03-01 14:06 ` Wilken Gottwalt
2021-03-02 17:20 ` Maxime Ripard
2021-03-06 11:05 ` Wilken Gottwalt
2021-03-08 16:58 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210301150635.480934a8@monster.powergraphx.local \
--to=wilken.gottwalt@posteo.net \
--cc=baolin.wang7@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=jernej.skrabec@siol.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=ohad@wizery.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox