* [PATCH -next RESEND] mfd: ene-kb3930: Make symbol 'kb3930_power_off' static
@ 2021-03-08 12:31 'Wei Yongjun
2021-03-10 9:05 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: 'Wei Yongjun @ 2021-03-08 12:31 UTC (permalink / raw)
To: weiyongjun1, Lee Jones, Lubomir Rintel
Cc: linux-kernel, kernel-janitors, Hulk Robot
From: Wei Yongjun <weiyongjun1@huawei.com>
The sparse tool complains as follows:
drivers/mfd/ene-kb3930.c:36:15: warning:
symbol 'kb3930_power_off' was not declared. Should it be static?
This symbol is not used outside of ene-kb3930.c, so this
commit marks it static.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Lubomir Rintel <lkundrak@v3.sk>
---
drivers/mfd/ene-kb3930.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/ene-kb3930.c b/drivers/mfd/ene-kb3930.c
index 83243e668e3f..1b73318d1f1f 100644
--- a/drivers/mfd/ene-kb3930.c
+++ b/drivers/mfd/ene-kb3930.c
@@ -33,7 +33,7 @@ struct kb3930 {
struct gpio_descs *off_gpios;
};
-struct kb3930 *kb3930_power_off;
+static struct kb3930 *kb3930_power_off;
#define EC_GPIO_WAVE 0
#define EC_GPIO_OFF_MODE 1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -next RESEND] mfd: ene-kb3930: Make symbol 'kb3930_power_off' static
2021-03-08 12:31 [PATCH -next RESEND] mfd: ene-kb3930: Make symbol 'kb3930_power_off' static 'Wei Yongjun
@ 2021-03-10 9:05 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2021-03-10 9:05 UTC (permalink / raw)
To: 'Wei Yongjun
Cc: Lubomir Rintel, linux-kernel, kernel-janitors, Hulk Robot
On Mon, 08 Mar 2021, 'Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> The sparse tool complains as follows:
>
> drivers/mfd/ene-kb3930.c:36:15: warning:
> symbol 'kb3930_power_off' was not declared. Should it be static?
>
> This symbol is not used outside of ene-kb3930.c, so this
> commit marks it static.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> Acked-by: Lubomir Rintel <lkundrak@v3.sk>
This should have been a Reviewed-by.
> ---
> drivers/mfd/ene-kb3930.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-10 9:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-08 12:31 [PATCH -next RESEND] mfd: ene-kb3930: Make symbol 'kb3930_power_off' static 'Wei Yongjun
2021-03-10 9:05 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox