From: Masami Hiramatsu <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Cao jin <jojing64@gmail.com>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
keescook@chromium.org, vbabka@suse.cz
Subject: Re: [PATCH] bootconfig: Update prototype of setup_boot_config()
Date: Fri, 12 Mar 2021 10:44:23 +0900 [thread overview]
Message-ID: <20210312104423.a90e3ea4887e496fe7da8be1@kernel.org> (raw)
In-Reply-To: <20210311090439.394c5293@gandalf.local.home>
Hi Steve,
On Thu, 11 Mar 2021 09:04:39 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Thu, 11 Mar 2021 18:50:21 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> > On Thu, 11 Mar 2021 16:52:13 +0800
> > Cao jin <jojing64@gmail.com> wrote:
> >
> > > Parameter "cmdline" has no use, drop it.
> >
> > OK, this looks good to me.
>
> Why is this using boot_command_line instead of what is passed in, which
> might be different?
I think you may know the reason...
commit f61872bb58a1cd8f0422aab1940eeee8be579d38
Author: Steven Rostedt (VMware) <rostedt@goodmis.org>
Date: Fri Feb 7 19:07:37 2020 -0500
bootconfig: Use parse_args() to find bootconfig and '--'
...
- p = strstr(cmdline, "bootconfig");
- if (!p || (p != cmdline && !isspace(*(p-1))) ||
- (p[10] && !isspace(p[10])))
+ strlcpy(tmp_cmdline, boot_command_line, COMMAND_LINE_SIZE);
+ parse_args("bootconfig", tmp_cmdline, NULL, 0, 0, 0, NULL,
+ bootconfig_params);
+
+ if (!bootconfig_found)
I guess since the boot_command_line has fixed length, it is safer to
allocate fixed length memory for tmp_cmdline. Is that correct?
Thank you,
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2021-03-12 1:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 8:52 [PATCH] bootconfig: Update prototype of setup_boot_config() Cao jin
2021-03-11 9:50 ` Masami Hiramatsu
2021-03-11 14:04 ` Steven Rostedt
2021-03-12 1:44 ` Masami Hiramatsu [this message]
2021-03-12 15:11 ` Steven Rostedt
2021-03-11 14:03 ` Steven Rostedt
2021-03-12 2:10 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210312104423.a90e3ea4887e496fe7da8be1@kernel.org \
--to=mhiramat@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=jojing64@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox