From: Masami Hiramatsu <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Cao jin <jojing64@gmail.com>,
linux-kernel@vger.kernel.org, mhiramat@kernel.org,
akpm@linux-foundation.org, keescook@chromium.org, vbabka@suse.cz
Subject: Re: [PATCH] bootconfig: Update prototype of setup_boot_config()
Date: Fri, 12 Mar 2021 11:10:26 +0900 [thread overview]
Message-ID: <20210312111026.a29a97de021aee0ff279850c@kernel.org> (raw)
In-Reply-To: <20210311090321.2c749b76@gandalf.local.home>
On Thu, 11 Mar 2021 09:03:21 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Thu, 11 Mar 2021 16:52:13 +0800
> Cao jin <jojing64@gmail.com> wrote:
>
> > Parameter "cmdline" has no use, drop it.
>
> Actually, I wonder if it should be using that instead of boot_command_line,
> as the cmdline passed in is boot_command_line plus anything that the
> architecture itself modified.
>
> Masami?
I think the policy is that boot_command_line is the reference command line
string passed from user, and the passed cmdline is modified by architecutre code.
But those are usually same in most cases, because boot_command_line was also
modified in setup_arch().
For example, x86 setup_arch() overwrites/modifies boot_command_line itself
by builtin_cmdline, and copy boot_command_line into the passed cmdline.
Thank you,
--
Masami Hiramatsu <mhiramat@kernel.org>
prev parent reply other threads:[~2021-03-12 2:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 8:52 [PATCH] bootconfig: Update prototype of setup_boot_config() Cao jin
2021-03-11 9:50 ` Masami Hiramatsu
2021-03-11 14:04 ` Steven Rostedt
2021-03-12 1:44 ` Masami Hiramatsu
2021-03-12 15:11 ` Steven Rostedt
2021-03-11 14:03 ` Steven Rostedt
2021-03-12 2:10 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210312111026.a29a97de021aee0ff279850c@kernel.org \
--to=mhiramat@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=jojing64@gmail.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox