From: Mark Brown <broonie@kernel.org>
To: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Cc: alsa-devel@alsa-project.org, shumingf@realtek.com,
flove@realtek.com, derek.fang@realtek.com,
Alexander.Deucher@amd.com, Basavaraj.Hiregoudar@amd.com,
Sunil-kumar.Dommati@amd.com, Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Chuhong Yuan <hslester96@gmail.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 2/2] ASoC: amd: fix multiple definition error
Date: Thu, 18 Mar 2021 13:02:27 +0000 [thread overview]
Message-ID: <20210318130227.GE5469@sirena.org.uk> (raw)
In-Reply-To: <1616013238-12254-2-git-send-email-Vijendar.Mukunda@amd.com>
[-- Attachment #1: Type: text/plain, Size: 501 bytes --]
On Thu, Mar 18, 2021 at 02:03:47AM +0530, Vijendar Mukunda wrote:
> make W=1 ARCH=x86_64 error:
> acp3x-rt5682-max9836.c:(.text+0x840): multiple definition of
> `soc_is_rltk_max';
> sound/soc/amd/acp-da7219-max98357a.o:acp-da7219-max98357a.c:
> (.text+0xd00):first defined here
In general you should put fixes at the start of the patch series, or if
this is a fix for patch 1 that was spotted by the bot when it was posted
on the list then you should just roll your fix into new versions of
patch 1.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-03-18 13:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 20:33 [PATCH v4 1/2] ASoC: amd: Add support for RT5682 codec in machine driver Vijendar Mukunda
2021-03-17 20:33 ` [PATCH v1 2/2] ASoC: amd: fix multiple definition error Vijendar Mukunda
2021-03-18 13:02 ` Mark Brown [this message]
2021-03-18 14:05 ` Mukunda,Vijendar
2021-03-18 13:00 ` [PATCH v4 1/2] ASoC: amd: Add support for RT5682 codec in machine driver Mark Brown
2021-03-18 14:04 ` Mukunda,Vijendar
2021-03-22 13:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210318130227.GE5469@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Alexander.Deucher@amd.com \
--cc=Basavaraj.Hiregoudar@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=derek.fang@realtek.com \
--cc=flove@realtek.com \
--cc=hslester96@gmail.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=shumingf@realtek.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox