From: "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, shumingf@realtek.com,
flove@realtek.com, derek.fang@realtek.com,
Alexander.Deucher@amd.com, Basavaraj.Hiregoudar@amd.com,
Sunil-kumar.Dommati@amd.com, Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Arnd Bergmann <arnd@arndb.de>,
Ravulapati Vishnu vardhan rao
<Vishnuvardhanrao.Ravulapati@amd.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Chuhong Yuan <hslester96@gmail.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] ASoC: amd: Add support for RT5682 codec in machine driver
Date: Thu, 18 Mar 2021 19:34:06 +0530 [thread overview]
Message-ID: <d9568571-6b67-5fea-4eb9-165039a3d7e8@amd.com> (raw)
In-Reply-To: <20210318130020.GD5469@sirena.org.uk>
On 18/03/21 6:30 pm, Mark Brown wrote:
> On Thu, Mar 18, 2021 at 02:03:46AM +0530, Vijendar Mukunda wrote:
>> +++ b/sound/soc/amd/acp-da7219-max98357a.c
>> @@ -1,27 +1,8 @@
>> -/*
>> - * Machine driver for AMD ACP Audio engine using DA7219 & MAX98357 codec
>> - *
>> - * Copyright 2017 Advanced Micro Devices, Inc.
>
> The conversion to SPDX really feels like it should at least be called
> out in the changelog, and probably a separate change.
>
will upload SPDX changes as a separate patch.
>> + /*
>> + * Set wclk to 48000 because the rate constraint of this driver is
>> + * 48000. ADAU7002 spec: "The ADAU7002 requires a BCLK rate that is
>> + * minimum of 64x the LRCLK sample rate." RT5682 is the only clk
>> + * source so for all codecs we have to limit bclk to 64X lrclk.
>> + */
>> + clk_set_rate(rt5682_dai_wclk, 48000);
>> + clk_set_rate(rt5682_dai_bclk, 48000 * 64);
>
> The driver should really check the return value of clk_set_rate(), it
> can fail.
>
We will add checks for return value of clk_set_rate() and will upload
new version
next prev parent reply other threads:[~2021-03-18 13:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 20:33 [PATCH v4 1/2] ASoC: amd: Add support for RT5682 codec in machine driver Vijendar Mukunda
2021-03-17 20:33 ` [PATCH v1 2/2] ASoC: amd: fix multiple definition error Vijendar Mukunda
2021-03-18 13:02 ` Mark Brown
2021-03-18 14:05 ` Mukunda,Vijendar
2021-03-18 13:00 ` [PATCH v4 1/2] ASoC: amd: Add support for RT5682 codec in machine driver Mark Brown
2021-03-18 14:04 ` Mukunda,Vijendar [this message]
2021-03-22 13:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9568571-6b67-5fea-4eb9-165039a3d7e8@amd.com \
--to=vijendar.mukunda@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Basavaraj.Hiregoudar@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=Vishnuvardhanrao.Ravulapati@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=derek.fang@realtek.com \
--cc=flove@realtek.com \
--cc=hslester96@gmail.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=shumingf@realtek.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox