* [PATCH] include: linux: Remove duplicate include of pgtable.h
@ 2021-03-23 3:13 Wan Jiabing
2021-03-23 7:57 ` Baoquan He
0 siblings, 1 reply; 2+ messages in thread
From: Wan Jiabing @ 2021-03-23 3:13 UTC (permalink / raw)
To: Dave Young, Baoquan He, Vivek Goyal, kexec, linux-kernel
Cc: kael_w, Wan Jiabing
linux/pgtable.h has been included at line 11 with annotation.
So we remove the duplicate one at line 8.
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
include/linux/crash_dump.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h
index a5192b718dbe..be79a45d7aa3 100644
--- a/include/linux/crash_dump.h
+++ b/include/linux/crash_dump.h
@@ -5,7 +5,6 @@
#include <linux/kexec.h>
#include <linux/proc_fs.h>
#include <linux/elf.h>
-#include <linux/pgtable.h>
#include <uapi/linux/vmcore.h>
#include <linux/pgtable.h> /* for pgprot_t */
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] include: linux: Remove duplicate include of pgtable.h
2021-03-23 3:13 [PATCH] include: linux: Remove duplicate include of pgtable.h Wan Jiabing
@ 2021-03-23 7:57 ` Baoquan He
0 siblings, 0 replies; 2+ messages in thread
From: Baoquan He @ 2021-03-23 7:57 UTC (permalink / raw)
To: Wan Jiabing; +Cc: Dave Young, Vivek Goyal, kexec, linux-kernel, kael_w
On 03/23/21 at 11:13am, Wan Jiabing wrote:
> linux/pgtable.h has been included at line 11 with annotation.
> So we remove the duplicate one at line 8.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Thanks for your posting. But this resend is still not good. I have
pasted the suggested log, wondering why you just ignore it and send v2
without updating, and also not marking this is v2. Please read
Documentation/process/submitting-patches.rst before you post next time.
Anyway, I have ack-ed Tian Tao's patch since his patch log is good
enough.
Thanks
Baoquan
> ---
> include/linux/crash_dump.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h
> index a5192b718dbe..be79a45d7aa3 100644
> --- a/include/linux/crash_dump.h
> +++ b/include/linux/crash_dump.h
> @@ -5,7 +5,6 @@
> #include <linux/kexec.h>
> #include <linux/proc_fs.h>
> #include <linux/elf.h>
> -#include <linux/pgtable.h>
> #include <uapi/linux/vmcore.h>
>
> #include <linux/pgtable.h> /* for pgprot_t */
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-23 7:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-23 3:13 [PATCH] include: linux: Remove duplicate include of pgtable.h Wan Jiabing
2021-03-23 7:57 ` Baoquan He
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox