From: Masami Hiramatsu <mhiramat@kernel.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] tools/bootconfig: Fix a build error accroding to undefined fallthrough
Date: Thu, 20 May 2021 23:07:38 +0900 [thread overview]
Message-ID: <20210520230738.605c92033e16c13b86f7c99c@kernel.org> (raw)
In-Reply-To: <162087519356.442660.11385099982318160180.stgit@devnote2>
Hi Steve,
Can you pick at least this fix since it is a critical bug?
Thank you,
On Thu, 13 May 2021 12:06:33 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:
> Since the "fallthrough" is defined only in the kernel, building
> lib/bootconfig.c as a part of user-space tools causes a build
> error.
>
> Add a dummy fallthrough to avoid the build error.
>
> Cc: stable@vger.kernel.org
> Fixes: 4c1ca831adb1 ("Revert "lib: Revert use of fallthrough pseudo-keyword in lib/"")
> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> ---
> tools/bootconfig/include/linux/bootconfig.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tools/bootconfig/include/linux/bootconfig.h b/tools/bootconfig/include/linux/bootconfig.h
> index 078cbd2ba651..de7f30f99af3 100644
> --- a/tools/bootconfig/include/linux/bootconfig.h
> +++ b/tools/bootconfig/include/linux/bootconfig.h
> @@ -4,4 +4,8 @@
>
> #include "../../../../include/linux/bootconfig.h"
>
> +#ifndef fallthrough
> +# define fallthrough
> +#endif
> +
> #endif
>
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2021-05-20 14:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-13 3:06 [PATCH] tools/bootconfig: Fix a build error accroding to undefined fallthrough Masami Hiramatsu
2021-05-20 14:07 ` Masami Hiramatsu [this message]
2021-05-20 15:47 ` Steven Rostedt
2021-05-20 23:07 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210520230738.605c92033e16c13b86f7c99c@kernel.org \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox