* [PATCH] remoteproc: pru: Remove redundant dev_err call in pru_rproc_probe()
@ 2021-06-01 8:31 Zhihao Cheng
2021-06-01 15:20 ` Mathieu Poirier
0 siblings, 1 reply; 3+ messages in thread
From: Zhihao Cheng @ 2021-06-01 8:31 UTC (permalink / raw)
To: ohad, bjorn.andersson, mathieu.poirier
Cc: linux-remoteproc, linux-kernel, chengzhihao1, yukuai3
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
---
drivers/remoteproc/pru_rproc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/remoteproc/pru_rproc.c b/drivers/remoteproc/pru_rproc.c
index e5778e476245..6491c731c6e2 100644
--- a/drivers/remoteproc/pru_rproc.c
+++ b/drivers/remoteproc/pru_rproc.c
@@ -822,8 +822,6 @@ static int pru_rproc_probe(struct platform_device *pdev)
mem_names[i]);
pru->mem_regions[i].va = devm_ioremap_resource(dev, res);
if (IS_ERR(pru->mem_regions[i].va)) {
- dev_err(dev, "failed to parse and map memory resource %d %s\n",
- i, mem_names[i]);
ret = PTR_ERR(pru->mem_regions[i].va);
return ret;
}
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] remoteproc: pru: Remove redundant dev_err call in pru_rproc_probe()
2021-06-01 8:31 [PATCH] remoteproc: pru: Remove redundant dev_err call in pru_rproc_probe() Zhihao Cheng
@ 2021-06-01 15:20 ` Mathieu Poirier
2021-06-02 1:07 ` Zhihao Cheng
0 siblings, 1 reply; 3+ messages in thread
From: Mathieu Poirier @ 2021-06-01 15:20 UTC (permalink / raw)
To: Zhihao Cheng
Cc: ohad, bjorn.andersson, linux-remoteproc, linux-kernel, yukuai3
On Tue, Jun 01, 2021 at 04:31:00PM +0800, Zhihao Cheng wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
> ---
> drivers/remoteproc/pru_rproc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/remoteproc/pru_rproc.c b/drivers/remoteproc/pru_rproc.c
> index e5778e476245..6491c731c6e2 100644
> --- a/drivers/remoteproc/pru_rproc.c
> +++ b/drivers/remoteproc/pru_rproc.c
> @@ -822,8 +822,6 @@ static int pru_rproc_probe(struct platform_device *pdev)
> mem_names[i]);
> pru->mem_regions[i].va = devm_ioremap_resource(dev, res);
> if (IS_ERR(pru->mem_regions[i].va)) {
> - dev_err(dev, "failed to parse and map memory resource %d %s\n",
> - i, mem_names[i]);
https://patchwork.kernel.org/project/linux-remoteproc/patch/20210511120426.5834-1-thunder.leizhen@huawei.com/
> ret = PTR_ERR(pru->mem_regions[i].va);
> return ret;
> }
> --
> 2.31.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] remoteproc: pru: Remove redundant dev_err call in pru_rproc_probe()
2021-06-01 15:20 ` Mathieu Poirier
@ 2021-06-02 1:07 ` Zhihao Cheng
0 siblings, 0 replies; 3+ messages in thread
From: Zhihao Cheng @ 2021-06-02 1:07 UTC (permalink / raw)
To: Mathieu Poirier
Cc: ohad, bjorn.andersson, linux-remoteproc, linux-kernel, yukuai3
在 2021/6/1 23:20, Mathieu Poirier 写道:
> On Tue, Jun 01, 2021 at 04:31:00PM +0800, Zhihao Cheng wrote:
>
> @@ -822,8 +822,6 @@ static int pru_rproc_probe(struct platform_device *pdev)
> mem_names[i]);
> pru->mem_regions[i].va = devm_ioremap_resource(dev, res);
> if (IS_ERR(pru->mem_regions[i].va)) {
> - dev_err(dev, "failed to parse and map memory resource %d %s\n",
> - i, mem_names[i]);
> https://patchwork.kernel.org/project/linux-remoteproc/patch/20210511120426.5834-1-thunder.leizhen@huawei.com/
Thanks for reminding. Ignore this patch.
>> ret = PTR_ERR(pru->mem_regions[i].va);
>> return ret;
>> }
>> --
>> 2.31.1
>>
> .
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-02 1:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-01 8:31 [PATCH] remoteproc: pru: Remove redundant dev_err call in pru_rproc_probe() Zhihao Cheng
2021-06-01 15:20 ` Mathieu Poirier
2021-06-02 1:07 ` Zhihao Cheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox