public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Arnd Bergmann <arnd@kernel.org>
Cc: linux-kbuild@vger.kernel.org,
	Masahiro Yamada <masahiroy@kernel.org>,
	Michal Marek <michal.lkml@markovi.net>,
	Arnd Bergmann <arnd@arndb.de>,
	David Brazdil <dbrazdil@google.com>,
	Marc Zyngier <maz@kernel.org>,
	Mikhail Petrov <Mikhail.Petrov@mir.dev>,
	linux-kernel@vger.kernel.org, mfaltesek@google.com
Subject: Re: [PATCH] kallsyms: fix nonconverging kallsyms table with lld
Date: Wed, 9 Jun 2021 04:05:31 -0700	[thread overview]
Message-ID: <20210609110531.GA1528247@roeck-us.net> (raw)
In-Reply-To: <20210204152957.1288448-1-arnd@kernel.org>

Hi Arnd,

On Thu, Feb 04, 2021 at 04:29:47PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> ARM randconfig builds with lld sometimes show a build failure
> from kallsyms:
> 
>   Inconsistent kallsyms data
>   Try make KALLSYMS_EXTRA_PASS=1 as a workaround
> 
> The problem is the veneers/thunks getting added by the linker extend
> the symbol table, which in turn leads to more veneers being needed,
> so it may take a few extra iterations to converge.
> 
> This bug has been fixed multiple times before, but comes back every time
> a new symbol name is used. lld uses a different set of idenitifiers from
> ld.bfd, so the additional ones need to be added as well.
> 
> I looked through the sources and found that arm64 and mips define similar
> prefixes, so I'm adding those as well, aside from the ones I observed. I'm
> not sure about powerpc64, which seems to already be handled through a
> section match, but if it comes back, the "__long_branch_" and "__plt_"
> prefixes would have to get added as well.
> 

This is such a whack-a-mole. The problem is hitting us yet again. I suspect
it may be due to a new version of lld using new symbols, but I didn't really
try to track it down. Is there an easy way to search for missed symbols ?

In this context .. is there a chance to apply [1] after all ? This is getting
really time consuming and annoying, and I really dislike having to fix the same
problem over and over again.

Thanks,
Guenter

---
[1] https://patchwork.kernel.org/project/linux-kbuild/patch/20200910153204.156871-1-linux@roeck-us.net/

  parent reply	other threads:[~2021-06-09 11:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04 15:29 [PATCH] kallsyms: fix nonconverging kallsyms table with lld Arnd Bergmann
2021-02-05  8:41 ` Masahiro Yamada
2021-06-09 11:05 ` Guenter Roeck [this message]
2021-06-09 11:24   ` Arnd Bergmann
2021-06-09 15:16     ` Guenter Roeck
2021-06-09 15:23       ` Arnd Bergmann
2021-06-09 19:15       ` Guenter Roeck
2021-06-09 20:30         ` Arnd Bergmann
2021-06-10 12:05           ` Guenter Roeck
2021-06-10 12:26             ` Arnd Bergmann
2021-06-21 11:47               ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210609110531.GA1528247@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=Mikhail.Petrov@mir.dev \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=dbrazdil@google.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=maz@kernel.org \
    --cc=mfaltesek@google.com \
    --cc=michal.lkml@markovi.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox