* Re: [PATCH] arm: mm: Prefer unsigned int to bare use of unsigned
[not found] <20210626065833.6653-1-wjc@cdjrlc.com>
@ 2021-06-26 9:21 ` Russell King (Oracle)
0 siblings, 0 replies; only message in thread
From: Russell King (Oracle) @ 2021-06-26 9:21 UTC (permalink / raw)
To: Jinchao Wang; +Cc: guillaume.tucker, linux-arm-kernel, linux-kernel
On Sat, Jun 26, 2021 at 02:58:33PM +0800, Jinchao Wang wrote:
> * By default, we write directly to secure registers. Platforms must
> * override this if they are running non-secure.
> */
> -static void l2c_write_sec(unsigned long val, void __iomem *base, unsigned reg)
> +static void l2c_write_sec(unsigned long val, void __iomem *base, unsigned int reg)
... and then I'll get another patch because this now goes over 80
characters. No thanks.
There is nothing inherently wrong with "unsigned" - it's always been
legal C, and I'd prefer to keep the code as-is under arch/arm in
regard of this.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
^ permalink raw reply [flat|nested] only message in thread