* [PATCH v2 1/1] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved
@ 2021-12-17 11:28 Andy Shevchenko
2021-12-21 2:11 ` Damien Le Moal
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2021-12-17 11:28 UTC (permalink / raw)
To: Andy Shevchenko, linux-ide, linux-kernel
Cc: Hans de Goede, Jens Axboe, Damien Le Moal
platform_get_irq() will print a message when it fails.
No need to repeat this.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v2: left !irq check untouched (Damien, Sergey)
drivers/ata/libahci_platform.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c
index bfa267e6f045..18296443ccba 100644
--- a/drivers/ata/libahci_platform.c
+++ b/drivers/ata/libahci_platform.c
@@ -579,11 +579,8 @@ int ahci_platform_init_host(struct platform_device *pdev,
int i, irq, n_ports, rc;
irq = platform_get_irq(pdev, 0);
- if (irq < 0) {
- if (irq != -EPROBE_DEFER)
- dev_err(dev, "no irq\n");
+ if (irq < 0)
return irq;
- }
if (!irq)
return -EINVAL;
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2 1/1] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved
2021-12-17 11:28 [PATCH v2 1/1] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved Andy Shevchenko
@ 2021-12-21 2:11 ` Damien Le Moal
0 siblings, 0 replies; 2+ messages in thread
From: Damien Le Moal @ 2021-12-21 2:11 UTC (permalink / raw)
To: Andy Shevchenko, linux-ide, linux-kernel; +Cc: Hans de Goede, Jens Axboe
On 12/17/21 20:28, Andy Shevchenko wrote:
> platform_get_irq() will print a message when it fails.
> No need to repeat this.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> v2: left !irq check untouched (Damien, Sergey)
> drivers/ata/libahci_platform.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c
> index bfa267e6f045..18296443ccba 100644
> --- a/drivers/ata/libahci_platform.c
> +++ b/drivers/ata/libahci_platform.c
> @@ -579,11 +579,8 @@ int ahci_platform_init_host(struct platform_device *pdev,
> int i, irq, n_ports, rc;
>
> irq = platform_get_irq(pdev, 0);
> - if (irq < 0) {
> - if (irq != -EPROBE_DEFER)
> - dev_err(dev, "no irq\n");
> + if (irq < 0)
> return irq;
> - }
> if (!irq)
> return -EINVAL;
>
Applied to for-5.17. Thanks !
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-21 2:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-17 11:28 [PATCH v2 1/1] ata: libahci_platform: Get rid of dup message when IRQ can't be retrieved Andy Shevchenko
2021-12-21 2:11 ` Damien Le Moal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox