The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javierm@redhat.com>
To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Cc: Thomas Zimmermann <tzimmermann@suse.de>,
	Javier Martinez Canillas <javierm@redhat.com>,
	Daniel Vetter <daniel@ffwll.ch>, Dave Airlie <airlied@redhat.com>,
	David Airlie <airlied@linux.ie>
Subject: [PATCH v3 02/10] drm/ast: Replace module-init boiler-plate code with DRM helpers
Date: Wed, 22 Dec 2021 09:28:23 +0100	[thread overview]
Message-ID: <20211222082831.196562-3-javierm@redhat.com> (raw)
In-Reply-To: <20211222082831.196562-1-javierm@redhat.com>

From: Thomas Zimmermann <tzimmermann@suse.de>

Remove custom ast_init() and ast_exit() functions and initialize the
module with DRM module helpers.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
---

(no changes since v1)

 drivers/gpu/drm/ast/ast_drv.c | 18 ++----------------
 1 file changed, 2 insertions(+), 16 deletions(-)

diff --git a/drivers/gpu/drm/ast/ast_drv.c b/drivers/gpu/drm/ast/ast_drv.c
index 6d8613f6fe1c..7465c4f0156a 100644
--- a/drivers/gpu/drm/ast/ast_drv.c
+++ b/drivers/gpu/drm/ast/ast_drv.c
@@ -34,6 +34,7 @@
 #include <drm/drm_crtc_helper.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_gem_vram_helper.h>
+#include <drm/drm_module.h>
 #include <drm/drm_probe_helper.h>
 
 #include "ast_drv.h"
@@ -230,22 +231,7 @@ static struct pci_driver ast_pci_driver = {
 	.driver.pm = &ast_pm_ops,
 };
 
-static int __init ast_init(void)
-{
-	if (drm_firmware_drivers_only() && ast_modeset == -1)
-		return -EINVAL;
-
-	if (ast_modeset == 0)
-		return -EINVAL;
-	return pci_register_driver(&ast_pci_driver);
-}
-static void __exit ast_exit(void)
-{
-	pci_unregister_driver(&ast_pci_driver);
-}
-
-module_init(ast_init);
-module_exit(ast_exit);
+drm_module_pci_driver_if_modeset(ast_pci_driver, ast_modeset);
 
 MODULE_AUTHOR(DRIVER_AUTHOR);
 MODULE_DESCRIPTION(DRIVER_DESC);
-- 
2.33.1


  parent reply	other threads:[~2021-12-22  8:28 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-22  8:28 [PATCH v3 00/10] drm: Make drivers to honour the nomodeset parameter Javier Martinez Canillas
2021-12-22  8:28 ` [PATCH v3 01/10] drm: Provide PCI module-init macros Javier Martinez Canillas
2021-12-22  8:28 ` Javier Martinez Canillas [this message]
2021-12-22  8:28 ` [PATCH v3 03/10] drm/bochs: Replace module-init boiler-plate code with DRM helpers Javier Martinez Canillas
2021-12-22 10:21   ` Gerd Hoffmann
2021-12-22 12:18     ` Javier Martinez Canillas
2021-12-22  8:28 ` [PATCH v3 04/10] drm/cirrus: " Javier Martinez Canillas
2021-12-22  8:28 ` [PATCH v3 05/10] drm/hisilicon/hibmc: Replace module initialization " Javier Martinez Canillas
2021-12-22  8:28 ` [PATCH v3 06/10] drm: Provide platform module-init macro Javier Martinez Canillas
2021-12-22  8:28 ` [PATCH v3 07/10] drm/imx/dcss: Replace module initialization with DRM helpers Javier Martinez Canillas
2021-12-22  8:28 ` [PATCH v3 08/10] drm/komeda: " Javier Martinez Canillas
2021-12-22  8:28 ` [PATCH v3 09/10] drm/arm/hdlcd: " Javier Martinez Canillas
2021-12-22  8:28 ` [PATCH v3 10/10] drm/malidp: " Javier Martinez Canillas
2022-01-11  8:52 ` [PATCH v3 00/10] drm: Make drivers to honour the nomodeset parameter Thomas Zimmermann
2022-01-19  9:09 ` Javier Martinez Canillas
2022-01-19 18:49 ` Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211222082831.196562-3-javierm@redhat.com \
    --to=javierm@redhat.com \
    --cc=airlied@linux.ie \
    --cc=airlied@redhat.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox