From: Javier Martinez Canillas <javierm@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Thomas Zimmermann <tzimmermann@suse.de>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v3 03/10] drm/bochs: Replace module-init boiler-plate code with DRM helpers
Date: Wed, 22 Dec 2021 13:18:57 +0100 [thread overview]
Message-ID: <7b07b437-2bc1-0194-233b-cc6d6c70cfd5@redhat.com> (raw)
In-Reply-To: <20211222102135.fhtfkinp2u6yjwx3@sirius.home.kraxel.org>
Hello Gerd,
On 12/22/21 11:21, Gerd Hoffmann wrote:
> On Wed, Dec 22, 2021 at 09:28:24AM +0100, Javier Martinez Canillas wrote:
>> -static int __init bochs_init(void)
>> -{
>> - if (drm_firmware_drivers_only() && bochs_modeset == -1)
>> - return -EINVAL;
>
> Also cleanup bochs_modeset? I guess its not used any more after this
> patch ...
>
That's still used. It is passed as an argument to the macro:
drm_module_pci_driver_if_modeset(bochs_pci_driver, bochs_modeset);
Best regards,
--
Javier Martinez Canillas
Linux Engineering
Red Hat
next prev parent reply other threads:[~2021-12-22 12:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 8:28 [PATCH v3 00/10] drm: Make drivers to honour the nomodeset parameter Javier Martinez Canillas
2021-12-22 8:28 ` [PATCH v3 01/10] drm: Provide PCI module-init macros Javier Martinez Canillas
2021-12-22 8:28 ` [PATCH v3 02/10] drm/ast: Replace module-init boiler-plate code with DRM helpers Javier Martinez Canillas
2021-12-22 8:28 ` [PATCH v3 03/10] drm/bochs: " Javier Martinez Canillas
2021-12-22 10:21 ` Gerd Hoffmann
2021-12-22 12:18 ` Javier Martinez Canillas [this message]
2021-12-22 8:28 ` [PATCH v3 04/10] drm/cirrus: " Javier Martinez Canillas
2021-12-22 8:28 ` [PATCH v3 05/10] drm/hisilicon/hibmc: Replace module initialization " Javier Martinez Canillas
2021-12-22 8:28 ` [PATCH v3 06/10] drm: Provide platform module-init macro Javier Martinez Canillas
2021-12-22 8:28 ` [PATCH v3 07/10] drm/imx/dcss: Replace module initialization with DRM helpers Javier Martinez Canillas
2021-12-22 8:28 ` [PATCH v3 08/10] drm/komeda: " Javier Martinez Canillas
2021-12-22 8:28 ` [PATCH v3 09/10] drm/arm/hdlcd: " Javier Martinez Canillas
2021-12-22 8:28 ` [PATCH v3 10/10] drm/malidp: " Javier Martinez Canillas
2022-01-11 8:52 ` [PATCH v3 00/10] drm: Make drivers to honour the nomodeset parameter Thomas Zimmermann
2022-01-19 9:09 ` Javier Martinez Canillas
2022-01-19 18:49 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b07b437-2bc1-0194-233b-cc6d6c70cfd5@redhat.com \
--to=javierm@redhat.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tzimmermann@suse.de \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox