From: Masami Hiramatsu <mhiramat@kernel.org>
To: Geliang Tang <geliang.tang@suse.com>
Cc: "Steven Rostedt (VMware)" <rostedt@goodmis.org>,
Chuck Lever <chuck.lever@oracle.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing: fix mismatched comment in __string_len
Date: Fri, 24 Dec 2021 22:48:20 +0900 [thread overview]
Message-ID: <20211224224820.cd2f6b2289d7c741cf1f8ba6@kernel.org> (raw)
In-Reply-To: <5c012db463392d0e6d4f0636203d778962ad060a.1640170494.git.geliang.tang@suse.com>
On Wed, 22 Dec 2021 19:00:25 +0800
Geliang Tang <geliang.tang@suse.com> wrote:
> Here __assign_str_len() should be used for the __string_len type, instead
> of __assign_str().
>
Yeah, the comment in the above line is correct :)
Reviewed-by: Masami Hiramatsu <mhiramat@kernel.org>
Thanks!
> Signed-off-by: Geliang Tang <geliang.tang@suse.com>
> ---
> samples/trace_events/trace-events-sample.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/samples/trace_events/trace-events-sample.h b/samples/trace_events/trace-events-sample.h
> index 5ab74fc9a2df..cbbbb83beced 100644
> --- a/samples/trace_events/trace-events-sample.h
> +++ b/samples/trace_events/trace-events-sample.h
> @@ -155,7 +155,7 @@
> *
> * To assign this string, use the helper macro __assign_str_len().
> *
> - * __assign_str(foo, bar, len);
> + * __assign_str_len(foo, bar, len);
> *
> * Then len + 1 is allocated to the ring buffer, and a nul terminating
> * byte is added. This is similar to:
> --
> 2.31.1
>
--
Masami Hiramatsu <mhiramat@kernel.org>
prev parent reply other threads:[~2021-12-24 13:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 11:00 [PATCH] tracing: fix mismatched comment in __string_len Geliang Tang
2021-12-24 13:48 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211224224820.cd2f6b2289d7c741cf1f8ba6@kernel.org \
--to=mhiramat@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=geliang.tang@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox